Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 19 Jan 2021 08:23:20 -0800
From:   Sean Christopherson <seanjc@google.com>
To:     Borislav Petkov <bp@alien8.de>
Cc:     Paolo Bonzini <pbonzini@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, x86@kernel.org,
        Andy Lutomirski <luto@kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org, Tom Lendacky <thomas.lendacky@amd.com>,
        Brijesh Singh <brijesh.singh@amd.com>
Subject: Re: [PATCH] x86/sev: Add AMD_SEV_ES_GUEST Kconfig for including
 SEV-ES support
Message-ID: <YAcHeOyluQY9C6HK@google.com>
References: <20210116002517.548769-1-seanjc@google.com>
 <20210118202931.GI30090@zn.tnic>
 <5f7bbd70-35c3-24ca-7ec5-047c71b16b1f@redhat.com>
 <20210118204701.GJ30090@zn.tnic>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210118204701.GJ30090@zn.tnic>
Precedence: bulk

On Mon, Jan 18, 2021, Borislav Petkov wrote:
> On Mon, Jan 18, 2021 at 09:32:07PM +0100, Paolo Bonzini wrote:
> > I think it makes sense because AMD_SEV_ES_GUEST's #VC handling is quite a
> > bit of code that you may not want or need.
> 
> Quite a bit of code which ends up practically enabled on the majority of
> distros.
> 
> And it ain't about savings of whopping KiBs. And yet another Kconfig symbol
> in our gazillion Kconfig symbols space means ugly ifdeffery and paying
> attention to randconfig builds.
> 
> For tailored configs you simply disable AMD_MEM_ENCRYPT on !AMD hw and
> all done.

It was the AMD_MEM_ENCRYPT_ACTIVE_BY_DEFAULT dependency that tripped me up.  To
get KVM to enable SEV/SEV-ES by default, that needs to be enabled, which in turn
requires AMD_MEM_ENCRYPT=y.  I didn't realize that there isn't actually a
dependency on AMD_MEM_ENCRYPT=y

> So I don't see the point for this.

Agreed, I'll send a KVM patch to remove the AMD_MEM_ENCRYPT_ACTIVE_BY_DEFAULT
dependency.