Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     "Bedel, Alban" <alban.bedel@aerq.com>
CC:     Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net v2] net: mscc: ocelot: Fix multicast to the CPU port
Thread-Topic: [PATCH net v2] net: mscc: ocelot: Fix multicast to the CPU port
Thread-Index: AQHW7mxY7uaoYquUzEO/44xBBVvQwKovKEqA
Date:   Tue, 19 Jan 2021 16:46:01 +0000
Message-ID: <20210119164601.dplx4js4wzhnmw6r@skbuf>
References: <20210119140638.203374-1-alban.bedel@aerq.com>
In-Reply-To: <20210119140638.203374-1-alban.bedel@aerq.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <EFA47A8F6B01E145B71C8F1672496301@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 5c7465ba-c001-49c7-c666-08d8bc99b49e
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jan 2021 16:46:01.8278
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Yl4zNiBDpH7OmR5Cu2gFEmkO10hewzhHeMW+3qnCETfpejF8Aez9x10wZwPPmCr3AFU11QKggvJQYx7oUiYeRw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6701
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jan 19, 2021 at 03:06:38PM +0100, Alban Bedel wrote:
> Multicast entries in the MAC table use the high bits of the MAC
> address to encode the ports that should get the packets. But this port
> mask does not work for the CPU port, to receive these packets on the
> CPU port the MAC_CPU_COPY flag must be set.
>=20
> Because of this IPv6 was effectively not working because neighbor
> solicitations were never received. This was not apparent before commit
> 9403c158 (net: mscc: ocelot: support IPv4, IPv6 and plain Ethernet mdb
> entries) as the IPv6 entries were broken so all incoming IPv6
> multicast was then treated as unknown and flooded on all ports.
>=20
> To fix this problem rework the ocelot_mact_learn() to set the
> MAC_CPU_COPY flag when a multicast entry that target the CPU port is
> added. For this we have to read back the ports endcoded in the pseudo
> MAC address by the caller. It is not a very nice design but that avoid
> changing the callers and should make backporting easier.
>=20
> Signed-off-by: Alban Bedel <alban.bedel@aerq.com>
> Fixes: 9403c158b872 ("net: mscc: ocelot: support IPv4, IPv6 and plain Eth=
ernet mdb entries")
>=20
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Tested-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Thanks!=