Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 19 Jan 2021 11:30:41 -0800
From:   Kees Cook <keescook@chromium.org>
To:     Bhaskara Budiredla <bbudiredla@marvell.com>
Cc:     Ulf Hansson <ulf.hansson@linaro.org>,
        Colin Cross <ccross@android.com>,
        Tony Luck <tony.luck@intel.com>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [EXT] Re: [PATCH v4 1/2] mmc: Support kmsg dumper based on
 pstore/blk
Message-ID: <202101191130.4A8EC5F9@keescook>
References: <20201223144033.32571-1-bbudiredla@marvell.com>
 <20201223144033.32571-2-bbudiredla@marvell.com>
 <CAPDyKFq41CQ8JbyAS0+k26=Cyf=KcOpdeD+VmY1AZxbh4D6f9w@mail.gmail.com>
 <CY4PR1801MB207022E70C53D0DA87EB3F22DEA31@CY4PR1801MB2070.namprd18.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CY4PR1801MB207022E70C53D0DA87EB3F22DEA31@CY4PR1801MB2070.namprd18.prod.outlook.com>
Precedence: bulk

On Tue, Jan 19, 2021 at 04:11:31AM +0000, Bhaskara Budiredla wrote:
> Do you see any issues to ACK this if the mmc pstore
> registration is through register_pstore_blk()?
> As Uffe said, eMMC would need to go through
> psblk_generic_blk_read()/write() instead of
> mmcpstore_read()/write().

I would be fine with that; yes.

-- 
Kees Cook