Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 19 Jan 2021 21:39:38 +0100
From:   Alexandre Belloni <alexandre.belloni@bootlin.com>
To:     Steen Hegelund <steen.hegelund@microchip.com>
Cc:     Philipp Zabel <p.zabel@pengutronix.de>,
        Andrew Lunn <andrew@lunn.ch>,
        Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
        Gregory Clement <gregory.clement@bootlin.com>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/3] reset: mchp: sparx5: add switch reset driver
Message-ID: <20210119203938.GQ3666@piout.net>
References: <20210114162432.3039657-1-steen.hegelund@microchip.com>
 <20210114162432.3039657-3-steen.hegelund@microchip.com>
 <20210119203710.GP3666@piout.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210119203710.GP3666@piout.net>
Precedence: bulk

On 19/01/2021 21:37:16+0100, Alexandre Belloni wrote:
> On 14/01/2021 17:24:31+0100, Steen Hegelund wrote:
> > +static int sparx5_switch_reset(struct reset_controller_dev *rcdev,
> > +			       unsigned long id)
> > +{
> > +	struct mchp_reset_context *ctx =
> > +		container_of(rcdev, struct mchp_reset_context, rcdev);
> > +	u32 val;
> > +
> 
> I would ensure the reset only happens once here else I'm not sure how
> you could do it from the individual drivers.
> 

Ok, the core is taking care of that, nice.


-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com