Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3087663pxb; Tue, 19 Jan 2021 13:29:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJx8WRaNU97Iut5GingQuT8slkC/4kvgKGxnyPF1FoIPRndkKV+t9YDNMQCwszI3KufGOL6O X-Received: by 2002:a05:6402:5246:: with SMTP id t6mr4928534edd.62.1611091744987; Tue, 19 Jan 2021 13:29:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611091744; cv=none; d=google.com; s=arc-20160816; b=NcRJKDupvJrABuyYXIdpj618wq4/t9MtAXJJl8snTRfSWaDbtr+8yJdbRQhGQF41Yd ihteJQOagiIoX9dKtufhjxpS3SPGoO+waUYZUNAzHi9ThZNXVNI8h79tJLvFDXZHPOTG mGYHFX1ELrJAgmFBgylHGy7yDCF7PrfqhRRYmutJXKL2+VVT1rEkTroKGtx8uRW41NxS y40TTn/mHxb7DAyzjFWQIjsBPh53MHrLpztu4DI8/J7OWrudlKF64YOQvkm2I5thRC/O tqMtF3LyH6Wk9hpOicca6Cim07dFhG1mRlAIWHCDJ5yhDJgndraog00jCV5nGUp95kiz Gr7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=Zs+ev1hHQiNd791Ta89J/gVTGYoWRujQkdg3a4FAzjo=; b=GzFvYOKeSdCtDktKrtFkVMurRlh4GaYV2Cu4XJvbCHg0p4ozu727gUoJ4xTcKTYOit 8McJLA6PObLzSQYqi53tmOqBKlF8be0uhaT5pFaU6q8JVbwVKqokOcMF1+JspTLtP5PG wX6NPUI7GLlxOnP5tPC+UDY5ADylEKWGsD00vqbUniAoAtIGZ6Cvpo4rKmRoHdcMePVX 2GrTiaiC1Vv6lH+8kJfdoCZ1me324ZI5HdpcGIuSaqdsPvCb4yLZ8ykm0/dXFgqtLT8Q pFkOKgz527bnrw/2YHiyP4+Ifra73xY9iySYYlaqo1cZN+1Tk5rogPwFjMxxwjL5SRFt KBEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hyHE3pqx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r29si30197edx.223.2021.01.19.13.28.37; Tue, 19 Jan 2021 13:29:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hyHE3pqx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729302AbhASV0x (ORCPT + 99 others); Tue, 19 Jan 2021 16:26:53 -0500 Received: from mail.kernel.org ([198.145.29.99]:43370 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728993AbhASV0R (ORCPT ); Tue, 19 Jan 2021 16:26:17 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8626122D08; Tue, 19 Jan 2021 21:25:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611091536; bh=m2NmUkVbZFqNYxEiipm2cSpkCjD68PKieK6nRK/uEZE=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=hyHE3pqxSgelS0zn5RME0voJ8QHAzxRaFLzY5H30Qpa7kCxG8OyBg8cMEvw/dSC1V I+7XvCxsxvsMt/r49nMHePxICOVfl+sTdBrEK4KzAv15ae+3LlK7HWRu6FpGi6Muph VNgBRx3D7rxt46XRREE0gqQ21cZsnBQqOrzJCYPWXsovAN6JOC3o0TAETdAFT63+iS hzW37fS/n9cPCu2v3hW/p0YTmEs4TzgEksy0nSp9HovD8fsWwIcC/iCrvbZoOyivga gzH3qvOlHvhq714BJga/FrHb67LBnLnftKtcOHSA4n/7QJC44vk4nNp7MWi1AY+DvL +wCZkRL/WjvMw== Subject: Re: [PATCH 0/2] introduce DUMP_PREFIX_UNHASHED for hex dumps To: Steven Rostedt Cc: Kees Cook , Matthew Wilcox , Sergey Senozhatsky , Andrew Morton , linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, Petr Mladek , roman.fietze@magna.com, John Ogness , linux-mm@kvack.org, Akinobu Mita References: <20210116220950.47078-1-timur@kernel.org> <20210118182635.GD2260413@casper.infradead.org> <20210119014725.GH2260413@casper.infradead.org> <202101191135.A78A570@keescook> <29122c86-bfea-2f25-d111-00641cc660ba@kernel.org> <20210119151045.15c1fee3@gandalf.local.home> <184ab5eb-2508-0761-36c6-061d509fe104@kernel.org> <20210119161524.31c695d3@gandalf.local.home> From: Timur Tabi Message-ID: Date: Tue, 19 Jan 2021 15:25:34 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210119161524.31c695d3@gandalf.local.home> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/19/21 3:15 PM, Steven Rostedt wrote: > When it's not related to any symbol, doesn't it still produce an offset > with something close by, that could still give you information that's > better than a hashed number. No. I often need the actual unhashed address in the hex dump so that I can see if some other pointer is correct. For example, I could be doing pointer math to calculate the address of some data inside a block. In this case, I would %px the pointer, and then hex_dump the block. I can then see not only where inside the block the pointer is pointing to, but what data it points to.