Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 19 Jan 2021 16:08:03 -0600
From:   Bjorn Helgaas <helgaas@kernel.org>
To:     Daniele Palmas <dnlplm@gmail.com>
Cc:     Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Loic Poulain <loic.poulain@linaro.org>
Subject: Re: [PATCH 1/1] PCI: add Telit Vendor ID
Message-ID: <20210119220803.GA2510309@bjorn-Precision-5520>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210119220619.GA2510101@bjorn-Precision-5520>
Precedence: bulk

On Tue, Jan 19, 2021 at 04:06:21PM -0600, Bjorn Helgaas wrote:
> On Tue, Jan 19, 2021 at 11:27:57AM +0100, Daniele Palmas wrote:
> > Add Telit Vendor ID to pci_ids.h
> 
> From the top of the file:
> 
>  *      Do not add new entries to this file unless the definitions
>  *      are shared between multiple drivers.
> 
> If this is the case, include this patch in a series that adds multiple
> uses or mention the uses in this commit log.

Also, when you do, follow the subject convention (run "git log
--oneline include/linux/pci_ids.h" to see it).

> > Signed-off-by: Daniele Palmas <dnlplm@gmail.com>
> > ---
> > Reference: https://pcisig.com/membership/member-companies?combine=telit
> > ---
> >  include/linux/pci_ids.h | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> > index d8156a5dbee8..b10a04783287 100644
> > --- a/include/linux/pci_ids.h
> > +++ b/include/linux/pci_ids.h
> > @@ -2590,6 +2590,8 @@
> >  
> >  #define PCI_VENDOR_ID_AMAZON_ANNAPURNA_LABS	0x1c36
> >  
> > +#define PCI_VENDOR_ID_TELIT		0x1c5d
> > +
> >  #define PCI_VENDOR_ID_CIRCUITCO		0x1cc8
> >  #define PCI_SUBSYSTEM_ID_CIRCUITCO_MINNOWBOARD	0x0001
> >  
> > -- 
> > 2.17.1
> >