Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 19 Jan 2021 15:04:00 +0100
From:   Thierry Reding <thierry.reding@gmail.com>
To:     JC Kuo <jckuo@nvidia.com>
Cc:     gregkh@linuxfoundation.org, robh@kernel.org, jonathanh@nvidia.com,
        kishon@ti.com, linux-tegra@vger.kernel.org,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, nkristam@nvidia.com
Subject: Re: [PATCH v6 14/15] usb: host: xhci-tegra: Unlink power domain
 devices
Message-ID: <YAbm0ELbAiFIZ+9G@ulmo>
References: <20210119085546.725005-1-jckuo@nvidia.com>
 <20210119085546.725005-15-jckuo@nvidia.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="9nt/UnHYaVisIkOl"
Content-Disposition: inline
In-Reply-To: <20210119085546.725005-15-jckuo@nvidia.com>
User-Agent: Mutt/2.0.4 (26f41dd1) (2020-12-30)
Precedence: bulk


--9nt/UnHYaVisIkOl
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jan 19, 2021 at 04:55:45PM +0800, JC Kuo wrote:
> This commit unlinks xhci-tegra platform device with SS/host power
> domain devices. Reasons for this change is - at ELPG entry, PHY
> sleepwalk and wake configuration need to be done before powering
> down SS/host partitions, and PHY need be powered off after powering
> down SS/host partitions. Sequence looks like roughly below:
>=20
>   tegra_xusb_enter_elpg() -> xhci_suspend()
>                           -> enable PHY sleepwalk and wake if needed
>                           -> power down SS/host partitions
>                           -> power down PHY
>=20
> If SS/host power domains are linked to xhci-tegra platform device, we
> are not able to perform the sequence like above.
>=20
> This commit introduces:
>   1. tegra_xusb_unpowergate_partitions() to power up SS and host
>      partitions together. If SS/host power domain devices are
>      available, it invokes pm_runtime_get_sync() to request power
>      driver to power up partitions; If power domain devices are not
>      available, tegra_powergate_sequence_power_up() will be used to
>      power up partitions.
>=20
>   2. tegra_xusb_powergate_partitions() to power down SS and host
>      partitions together. If SS/host power domain devices are
>      available, it invokes pm_runtime_put_sync() to request power
>      driver to power down partitions; If power domain devices are not
>      available, tegra_powergate_power_off() will be used to power down
>      partitions.
>=20
> Signed-off-by: JC Kuo <jckuo@nvidia.com>

Acked-by: Thierry Reding <treding@nvidia.com>

--9nt/UnHYaVisIkOl
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmAG5tAACgkQ3SOs138+
s6HtZg//YATKR0XCFqPsQh+D3HoLvJv6I3p39ntPOPsmRwuP5GJj+Z3Jb1pKbTwH
Kkf1V5pqOoMCgViGa/HVvqOokgs9JffGHDg67oLQqXnZv7KFoh7r9xpsFZkF0anG
5RB7ygKIf9o7e6IZQDX9XWM25diE4dQ/lrfY/cKYEEcIXBNeEtbIDe9lxydUPWxW
zcL8qfW2woN8iq/Nl4po2h8fZb3BvPn4zZBVdQJP4FxQF5HGNJJABVXeh10yZzHL
/CmD0ekojMtRiNSQUtxr7AlD/Vq9YqPkVNgZc/prhoTVswlJPO9tSO3hVYPDRpU4
HIqro3nRsg5BjA6JQGAfO1qP2I3jyo+r5WIbVrBzVP0fRZxbtzTt7Y9juieqgc+l
9gEPhSqUMupHAXgs+x1V5WzxOVRh+h67uIYsxfFSWRrXlvUScefdZE2bMCcUgJxe
DDm5/39okjToZafBcvvC2R5Ky7i2qM+KW+3I7dNO93rIdDIzk9GmoXeq8SKCSDei
lLjHZD4OZWKWHh3j5tIUsIqPQvOd6Oqf8HbNDpj5aN8l+YHWH2Q5DalqL/BXLgdD
WFYPuQi9Azrj3z9dMm7E68w8VHAc0yNhpieLpYPihIJDfEGTnxV3Omvb72ZgFG7R
hoA5lXMMf2GN25yq3gYtWzNITEaTtnrpv+EuPkJ3gMSOROi7OH8=
=g0x5
-----END PGP SIGNATURE-----

--9nt/UnHYaVisIkOl--