Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 19 Jan 2021 20:32:19 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Joe Perches <joe@perches.com>
CC:     James Bottomley <James.Bottomley@HansenPartnership.com>,
        "Christian Benvenuti" <benve@cisco.com>,
        Nelson Escobar <neescoba@cisco.com>,
        "Doug Ledford" <dledford@redhat.com>, <linux-rdma@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, Greg KH <greg@kroah.com>
Subject: Re: [PATCH V2] RDMA: usnic: Fix misuse of sysfs_emit_at
Message-ID: <20210120003219.GA968146@nvidia.com>
References: <f4ce30f297be4678634b5be4917401767ee6ebc5.camel@perches.com>
 <6af0a6562b67a24e6233ed360189ba8071243035.camel@HansenPartnership.com>
 <5eb794b9c9bca0494d94b2b209f1627fa4e7b555.camel@perches.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <5eb794b9c9bca0494d94b2b209f1627fa4e7b555.camel@perches.com>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from mlx.ziepe.ca (142.162.115.133) by BL0PR02CA0126.namprd02.prod.outlook.com (2603:10b6:208:35::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.10 via Frontend Transport; Wed, 20 Jan 2021 00:32:20 +0000
Received: from jgg by mlx with local (Exim 4.94)        (envelope-from <jgg@nvidia.com>)        id 1l21Q3-0043ry-6V; Tue, 19 Jan 2021 20:32:19 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1611102745; bh=2FDQpZqc6k44lNzc+h2+vFJGEthCb/krNZCTKdaS2YA=;
        h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Date:
         From:To:CC:Subject:Message-ID:References:Content-Type:
         Content-Disposition:In-Reply-To:X-ClientProxiedBy:MIME-Version:
         X-MS-Exchange-MessageSentRepresentingType;
        b=QXvV6ai49oGDuQ2iBFy/DpBgnCKV35azmmrXOPOHV2BaSeaq5rt2ZUDndaYTaFXmS
         Bzv3wUFZoilYpQpUrUPPQeEFIiknH3Ct/IuD63XXw1oyd40uZfjt2DMzGbigzc5w/E
         Ml5TNUNShEncr+QKisUrYrtis3wZAI+2gLLoWjS88iC8fSVKPnmV7nnYfL+wUg4yXF
         6ff3zMZ+wue0jGsVk29uq3lvVwjUZOpSx0+UyovsDcb0K61uqN8F1uj3zsJdkpz1c1
         sOUwiAycmhNWmC/LiNFZLTSc8cAFySh3WqA9ba0fcxxB9MhlB4YP884a8EOBjJGaXF
         As/VBGMRZMVgg==
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jan 15, 2021 at 04:36:50PM -0800, Joe Perches wrote:
> In commit e28bf1f03b01 ("RDMA: Convert various random sprintf sysfs _show
> uses to sysfs_emit") I mistakenly used len = sysfs_emit_at to overwrite
> the last trailing space of potentially multiple entry output.
> 
> Instead use a more common style by removing the trailing space from the
> output formats and adding a prefixing space to the contination formats and
> converting the final terminating output newline from the defective
> 	len = sysfs_emit_at(buf, len, "\n");
> to the now appropriate and typical
> 	len += sysfs_emit_at(buf, len, "\n");
> 
> Fixes: e28bf1f03b01 ("RDMA: Convert various random sprintf sysfs _show uses to sysfs_emit")
> 
> Reported-by: James Bottomley <James.Bottomley@HansenPartnership.com>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>  drivers/infiniband/hw/usnic/usnic_ib_sysfs.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)

Applied to for-rc, thanks

Jason