Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH bpf-next v2] samples/bpf: Update README.rst and Makefile
 for manually compiling LLVM and clang
To:     Tiezhu Yang <yangtiezhu@loongson.cn>,
        Fangrui Song <maskray@google.com>
CC:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Nathan Chancellor <natechancellor@gmail.com>,
        Nick Desaulniers <ndesaulniers@google.com>,
        <netdev@vger.kernel.org>, <bpf@vger.kernel.org>,
        <clang-built-linux@googlegroups.com>,
        <linux-kernel@vger.kernel.org>, Xuefeng Li <lixuefeng@loongson.cn>
References: <1611042978-21473-1-git-send-email-yangtiezhu@loongson.cn>
 <20210119215815.efyerbwwq5x2o26q@google.com>
 <b526e0eb-f05f-1c3a-de8f-3d7e9bef73ee@loongson.cn>
From:   Yonghong Song <yhs@fb.com>
Message-ID: <cda075d8-0c80-5fbb-2b5c-571098560e55@fb.com>
Date:   Tue, 19 Jan 2021 19:06:11 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.6.1
In-Reply-To: <b526e0eb-f05f-1c3a-de8f-3d7e9bef73ee@loongson.cn>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [IPv6:2620:10d:c085:21c8::1290] (2620:10d:c090:400::5:4417) by MW4PR03CA0348.namprd03.prod.outlook.com (2603:10b6:303:dc::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3784.11 via Frontend Transport; Wed, 20 Jan 2021 03:06:13 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 28e7e036-80f3-46ca-ea9e-08d8bcf05a6e
X-MS-TrafficTypeDiagnostic: BYAPR15MB4246:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <BYAPR15MB42466F0A6DC045FADD8F6D85D3A20@BYAPR15MB4246.namprd15.prod.outlook.com>
X-FB-Source: Internal
X-MS-Oob-TLC-OOBClassifiers: OLM:5516;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: +BhJMJUuMUrTtKcK+RJf2E4mA7qw/P6Ul5IwmS+3b8uXMKb6e/j3a75TAzbMjHAymz/NWtTusH8dNFIph3VT/VscuzRshK7aazlXQc+awURof6abwV/EY40gnMjej+2gyv/Iqmtzb30m4ZHM3aOpIWTqE3yKsblqrO476v/o5c7Yvy8JCSzFgTyeXAaak/r/7gkxcl//KST3+ic1OW3Qpg443gweuiTdSWnyVoz5ODiFpmE5FtlM2FEWhEW264HFFn32n1YGb6ETXmX+BMhHgvhbhdtP2oZmDmVzO0ZD+Nyt6fqzYMB4n91awRm0x/DK1XiSuollSM7uilnKoxnBncnRgz9vANlp0+UwM7cAyEeCUgyEXnpdjldXUWwMzJ1++31pAoKii7tW/PqQgnhjo07I7iuOh3TC652NUsBYVHvzhGWiDpjWlpy9nv6qzj5hc7qX2O7glGEX9mN/3pdDQJdvtriR5mvVOS+hmk3xfkiLgMoiS5EeER38M0iVeRqBTsYbPTsdH5eAcusRkUfPJIRqvF42ic4tuJcCvv8aZ1z+iDxM2hj8OtQhnvRgEDt8
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR15MB4088.namprd15.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(346002)(39860400002)(396003)(366004)(376002)(966005)(110136005)(316002)(53546011)(86362001)(2906002)(8936002)(6486002)(31686004)(52116002)(66556008)(36756003)(83380400001)(5660300002)(186003)(54906003)(16526019)(8676002)(66476007)(478600001)(7416002)(31696002)(4326008)(15650500001)(2616005)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?VTNndEMyb0x4Zk9ma3MyeFlQdDhSZlZTTGN2UGZjR1BoeGhVdEdEdkttellm?=
 =?utf-8?B?TyswZS8wWGlwVzhaZDhWTHNYckRuZnJuRVdDcjlOb2lSMG1vUWVBcG4zYW9F?=
 =?utf-8?B?Mm5mdnZuZUFVeG5EWkgzT3ZEdGNUQzh3K1IzZEc3MjZ0S1p3WThOREdjeTRq?=
 =?utf-8?B?eHhWU3dEZzl3L1cveEpJenBjVTJMMkdtSCtia09SSWNOS3IyanM0dDluR2U0?=
 =?utf-8?B?UnRTVDA1TEd2M0M2WlhtZkdqM25yWEVjRlUrSW1SeDB5WXpJOXdZZ0l3TGlw?=
 =?utf-8?B?ZnBmU1lpbzJETDk0ZlpVSGdUWDhVbHZFSUlsb1RGMTVJOGJIWHRLR2x2VGpm?=
 =?utf-8?B?NzFPUHg0d2Ewbi9nVjM5VVl2bVk5OS9IWEo4ZGpIMEE3c1EwZTg3V1VETVNa?=
 =?utf-8?B?STBYM3VkVURWZ2ZXYWlOUllGOTlTalZMKzFWaThaTHJ3Mks5Ny85K2RkV0FI?=
 =?utf-8?B?UjhVbHg1Mjdjam12ekdaQkFvcjFNTUlDRDZFaVlXeUFjV0pIZFRVQXhvdEEw?=
 =?utf-8?B?YXhxbDBTeXlwOFpaWG5KTHhBMEpvZ1BnVERmamQ0eXA5MG1KYmtaZlJUcGZn?=
 =?utf-8?B?NXBOdXU2UVNLdjhNUTlsYzFKME5PcDJyck9ISkI4UkVEbEhZQ0ZHVG9sVkVS?=
 =?utf-8?B?UHU5V3owY2lic2x6UzdVWXRrRFVEWTlZaDVXSVNXQUNGdGxTRll6UDBOZUxR?=
 =?utf-8?B?ZnJHcUdaQm1QQTNLbWt6Z1U3ZzNkd1YrV3h4b1NleUllOVBTY0k0cEtmdXBW?=
 =?utf-8?B?bm1OM1FHeVBGZ1FtWXEyTDFERWxpZHBvcFhVcWpRNCt3aWE4R2lMOFlLWU1E?=
 =?utf-8?B?VVlIdWdSTUFvVHRoekljbk56bkxBNzk2dFVEd3pnU1cyOHZoeFAwdzA2SzQx?=
 =?utf-8?B?MzRiRzEwM2ZxTmc2bG5zWHdsN3VNMXU2VTZXaDZCYUlHeW9pek8zWDJaSHV3?=
 =?utf-8?B?NzFseEo1NlFRTUVJamlpanhyNWNNc1E5dGxVbUc4OVNOeHRyd1dwYi9WOXNR?=
 =?utf-8?B?L1hCOHdtb2xzNWJnNGR0TXZDeHFvUitiODZOY2lNRlhFU3ROQy9rNXdYL3BR?=
 =?utf-8?B?T3IwVUJwdFJFRFJncjRDWlRWMTdYaU9uaENvZkJDbWJiUk01cWJyNGZUZkxi?=
 =?utf-8?B?bXB1THNxQy90SHpGdG9OMmp0dXQ2V3VWb1h3clFycTZSdWJzUzhHaEFGZUUz?=
 =?utf-8?B?dzZRTnVLeWVkNG84R2trUjhOYjZoY1dYRFd1U0Yrc0JRcmdPSjZSU1ZMMmFh?=
 =?utf-8?B?ZXpITWoveUR2OExoWC9PS2JoUGExd0xtSE1wWUU3ck5zeEtEbEdEMGtMeDI5?=
 =?utf-8?B?TVhuRW9CSU9tVFNvSmU0bHFjbm51SjlvYXAwbDYyT3FKU0ZYY2M2d0t2anNx?=
 =?utf-8?B?WUtmUXlMZ2lFM3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 28e7e036-80f3-46ca-ea9e-08d8bcf05a6e
X-MS-Exchange-CrossTenant-AuthSource: BYAPR15MB4088.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jan 2021 03:06:17.1624
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6WgVCDE+qZg45Lja5QyDlX7YxiHwKm0Yxzajw359ZgzYKZiH4ULtW8VXNF9tfLnX
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB4246
X-OriginatorOrg: fb.com
Content-Transfer-Encoding: 8bit
X-Proofpoint-UnRewURL: 9 URL's were un-rewritten
MIME-Version: 1.0
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343,18.0.737
 definitions=2021-01-19_15:2021-01-18,2021-01-19 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 lowpriorityscore=0
 malwarescore=0 bulkscore=0 mlxlogscore=999 spamscore=0 adultscore=0
 suspectscore=0 mlxscore=0 phishscore=0 impostorscore=0 clxscore=1015
 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2009150000 definitions=main-2101200017
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 1/19/21 6:32 PM, Tiezhu Yang wrote:
> On 01/20/2021 05:58 AM, Fangrui Song wrote:
>> On 2021-01-19, Tiezhu Yang wrote:
>>> The current llvm/clang build procedure in samples/bpf/README.rst is
>>> out of date. See below that the links are not accessible any more.
>>>
>>> $ git clone 
>>> http://llvm.org/git/llvm.git 
>>> Cloning into 'llvm'...
>>> fatal: unable to access 
>>> 'http://llvm.org/git/llvm.git/ 
>>> ': Maximum (20) redirects followed
>>> $ git clone --depth 1 
>>> http://llvm.org/git/clang.git 
>>> Cloning into 'clang'...
>>> fatal: unable to access 
>>> 'http://llvm.org/git/clang.git/ 
>>> ': Maximum (20) redirects followed
>>>
>>> The llvm community has adopted new ways to build the compiler. There are
>>> different ways to build llvm/clang, the Clang Getting Started page 
>>> [1] has
>>> one way. As Yonghong said, it is better to just copy the build procedure
>>> in Documentation/bpf/bpf_devel_QA.rst to keep consistent.
>>>
>>> I verified the procedure and it is proved to be feasible, so we should
>>> update README.rst to reflect the reality. At the same time, update the
>>> related comment in Makefile.
>>>
>>> [1] 
>>> https://clang.llvm.org/get_started.html 
>>>
>>> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
>>> Acked-by: Yonghong Song <yhs@fb.com>
>>> ---
>>>
>>> v2: Update the commit message suggested by Yonghong,
>>>    thank you very much.
>>>
>>> samples/bpf/Makefile   |  2 +-
>>> samples/bpf/README.rst | 17 ++++++++++-------
>>> 2 files changed, 11 insertions(+), 8 deletions(-)
>>>
>>> diff --git a/samples/bpf/Makefile b/samples/bpf/Makefile
>>> index 26fc96c..d061446 100644
>>> --- a/samples/bpf/Makefile
>>> +++ b/samples/bpf/Makefile
>>> @@ -208,7 +208,7 @@ TPROGLDLIBS_xdpsock        += -pthread -lcap
>>> TPROGLDLIBS_xsk_fwd        += -pthread
>>>
>>> # Allows pointing LLC/CLANG to a LLVM backend with bpf support, 
>>> redefine on cmdline:
>>> -#  make M=samples/bpf/ LLC=~/git/llvm/build/bin/llc 
>>> CLANG=~/git/llvm/build/bin/clang
>>> +# make M=samples/bpf LLC=~/git/llvm-project/llvm/build/bin/llc 
>>> CLANG=~/git/llvm-project/llvm/build/bin/clang
>>> LLC ?= llc
>>> CLANG ?= clang
>>> OPT ?= opt
>>> diff --git a/samples/bpf/README.rst b/samples/bpf/README.rst
>>> index dd34b2d..d1be438 100644
>>> --- a/samples/bpf/README.rst
>>> +++ b/samples/bpf/README.rst
>>> @@ -65,17 +65,20 @@ To generate a smaller llc binary one can use::
>>> Quick sniplet for manually compiling LLVM and clang
>>> (build dependencies are cmake and gcc-c++)::
>>>
>>> - $ git clone 
>>> http://llvm.org/git/llvm.git 
>>> - $ cd llvm/tools
>>> - $ git clone --depth 1 
>>> http://llvm.org/git/clang.git 
>>> - $ cd ..; mkdir build; cd build
>>> - $ cmake .. -DLLVM_TARGETS_TO_BUILD="BPF;X86"
>>> - $ make -j $(getconf _NPROCESSORS_ONLN)
>>> + $ git clone https://github.com/llvm/llvm-project.git
>>> + $ mkdir -p llvm-project/llvm/build/install
>>
>> llvm-project/llvm/build/install is not used.
> 
> Yes, just mkdir -p llvm-project/llvm/build is OK.
> 
>>
>>> + $ cd llvm-project/llvm/build
>>> + $ cmake .. -G "Ninja" -DLLVM_TARGETS_TO_BUILD="BPF;X86" \
>>> +            -DLLVM_ENABLE_PROJECTS="clang"    \
>>> +            -DBUILD_SHARED_LIBS=OFF           \
>>
>> -DBUILD_SHARED_LIBS=OFF is the default. It can be omitted.
> 
> I search the related doc [1] [2], remove this option is OK for me.
> 
> BUILD_SHARED_LIBS:BOOL
> 
>      Flag indicating if each LLVM component (e.g. Support) is built as a 
> shared library (ON) or as a static library (OFF). Its default value is OFF.
> 
> [1] 
> https://www.llvm.org/docs/CMake.html 
> [2] 
> https://cmake.org/cmake/help/latest/variable/BUILD_SHARED_LIBS.html 
> 
>>
>>> + -DCMAKE_BUILD_TYPE=Release        \
>>> +            -DLLVM_BUILD_RUNTIME=OFF
>>
>> -DLLVM_BUILD_RUNTIME=OFF can be omitted if none of
>> compiler-rt/libc++/libc++abi is built.
> 
> I am not very sure about it because the default value of
> LLVM_BUILD_RUNTIME is ON? [3]
> 
> option(LLVM_BUILD_RUNTIME
> "Build the LLVM runtime libraries." ON)
> 
> [3] https://github.com/llvm/llvm-project/blob/main/llvm/CMakeLists.txt
> 
> If anyone has any more suggestions, please let me know.
> I will send v3 after waiting for other feedback.
> 
> By the way, Documentation/bpf/bpf_devel_QA.rst maybe need a separate
> patch to remove some cmake options?

Please submit updated this patch and Documentation/bpf/bpf_devel_QA.rst
together. This way, it is easy to cross check. Thanks.

> 
> Thanks,
> Tiezhu
> 
[...]