Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp12411pxb; Tue, 19 Jan 2021 23:19:33 -0800 (PST) X-Google-Smtp-Source: ABdhPJyEgP7+rp5AXVOCOPx+4rlX7Z6hSwySDK8hOTvlTyhL87x3/azGOj4hj6wDXXnXTdFPHY+z X-Received: by 2002:aa7:d511:: with SMTP id y17mr6424070edq.112.1611127173308; Tue, 19 Jan 2021 23:19:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611127173; cv=none; d=google.com; s=arc-20160816; b=eGrRY00qTN4FkXi3sHmR0v1UBZBqfo+33pb7DZrE5JGtcAE1t9y77H9cjGSYxaJNCm A+F8azWNm5rCuo9qJurNihhay/3J9HGHUVqoe7j3Ov/xSMXjr+2MqwyyzNrRLwbYSKYq ho+UICmOVbAl1KHidVe4wGXvgN3WqXOKLK8fpUq2VmgNIzQ/wjRW8BRG9OkM/cGQdTnU xD1REFPJ17969Im95YxC4Ke0+7vn7pEBBB7bpKoflx4ggwUkHx5nrOEMakYpC7T+xNHP d1btZKH4l0lEdbj9Flm0uVnjlumvFFYUvWDeARgxLUb3kCwIlBDY7A8rbW7FxLi2ybxK GaSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=m/i/zDH96SGvSIvj6ha0K29JxNpGUNSaoxzPPlDtZHI=; b=YdJkPEV4E2yzrxtY1Y/6eKyC2v6zV2OEviCphbgBQCVC1RsyHkaTKJCDManP/WkdYN sNNzkaGKsu+ozkWWlA+zlbKN4ZQ8tVh4UZ4+fp8AwWiCpEA1jkMsZqWVDUWqgxVGsE/f mwWG47dksX1JcInRB3SGISvMzNl4lxVQ/C637uYrPzyRfbgM3iXuCKqEIVB6O/SXsuAh cYgvunBDlhX82dbbX0n8KM2K+oxHYFOQ0NLhXqpSyyEt+DqTcTpx24b7hFVCjWdImYLP 4OypS4XbVjSoIwn6bnIZzLskUC5S0sbJOfGNTrbRAHYMGkN1cR+HgcuNzIOZkZLqytsP IhHg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h18si516534edv.41.2021.01.19.23.19.09; Tue, 19 Jan 2021 23:19:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727123AbhATHSI (ORCPT + 99 others); Wed, 20 Jan 2021 02:18:08 -0500 Received: from out30-42.freemail.mail.aliyun.com ([115.124.30.42]:37109 "EHLO out30-42.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726627AbhATHSG (ORCPT ); Wed, 20 Jan 2021 02:18:06 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R101e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04420;MF=abaci-bugfix@linux.alibaba.com;NM=1;PH=DS;RN=16;SR=0;TI=SMTPD_---0UMJjpYD_1611127009; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:abaci-bugfix@linux.alibaba.com fp:SMTPD_---0UMJjpYD_1611127009) by smtp.aliyun-inc.com(127.0.0.1); Wed, 20 Jan 2021 15:16:53 +0800 From: Jiapeng Zhong To: harry.wentland@amd.com Cc: sunpeng.li@amd.com, alexander.deucher@amd.com, christian.koenig@amd.com, airlied@linux.ie, daniel@ffwll.ch, luben.tuikov@amd.com, Eric.Bernstein@amd.com, Bhawanpreet.Lakha@amd.com, Rodrigo.Siqueira@amd.com, Dmytro.Laktyushkin@amd.com, yebin10@huawei.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jiapeng Zhong Subject: [PATCH] drm/amdgpu: Assign boolean values to a bool variable Date: Wed, 20 Jan 2021 15:16:47 +0800 Message-Id: <1611127007-39308-1-git-send-email-abaci-bugfix@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following coccicheck warnings: ./drivers/gpu/drm/amd/display/dc/dml/dcn30/display_rq_dlg_calc_30.c: 1009:6-16: WARNING: Assignment of 0/1 to bool variable. ./drivers/gpu/drm/amd/display/dc/dml/dcn30/display_rq_dlg_calc_30.c: 200:2-10: WARNING: Assignment of 0/1 to bool variable. Reported-by: Abaci Robot Signed-off-by: Jiapeng Zhong --- .../display/dc/dml/dcn30/display_rq_dlg_calc_30.c | 32 +++++++++++----------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_rq_dlg_calc_30.c b/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_rq_dlg_calc_30.c index 5b5916b..0f14f20 100644 --- a/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_rq_dlg_calc_30.c +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_rq_dlg_calc_30.c @@ -165,8 +165,8 @@ static void handle_det_buf_split(struct display_mode_lib *mode_lib, unsigned int swath_bytes_c = 0; unsigned int full_swath_bytes_packed_l = 0; unsigned int full_swath_bytes_packed_c = 0; - bool req128_l = 0; - bool req128_c = 0; + bool req128_l = false; + bool req128_c = false; bool surf_linear = (pipe_src_param.sw_mode == dm_sw_linear); bool surf_vert = (pipe_src_param.source_scan == dm_vert); unsigned int log2_swath_height_l = 0; @@ -191,37 +191,37 @@ static void handle_det_buf_split(struct display_mode_lib *mode_lib, total_swath_bytes = 2 * full_swath_bytes_packed_l; if (total_swath_bytes <= detile_buf_size_in_bytes) { //full 256b request - req128_l = 0; - req128_c = 0; + req128_l = false; + req128_c = false; swath_bytes_l = full_swath_bytes_packed_l; swath_bytes_c = full_swath_bytes_packed_c; } else if (!rq_param->yuv420) { - req128_l = 1; - req128_c = 0; + req128_l = true; + req128_c = false; swath_bytes_c = full_swath_bytes_packed_c; swath_bytes_l = full_swath_bytes_packed_l / 2; } else if ((double)full_swath_bytes_packed_l / (double)full_swath_bytes_packed_c < 1.5) { - req128_l = 0; - req128_c = 1; + req128_l = false; + req128_c = true; swath_bytes_l = full_swath_bytes_packed_l; swath_bytes_c = full_swath_bytes_packed_c / 2; total_swath_bytes = 2 * swath_bytes_l + 2 * swath_bytes_c; if (total_swath_bytes > detile_buf_size_in_bytes) { - req128_l = 1; + req128_l = true; swath_bytes_l = full_swath_bytes_packed_l / 2; } } else { - req128_l = 1; - req128_c = 0; + req128_l = true; + req128_c = false; swath_bytes_l = full_swath_bytes_packed_l/2; swath_bytes_c = full_swath_bytes_packed_c; total_swath_bytes = 2 * swath_bytes_l + 2 * swath_bytes_c; if (total_swath_bytes > detile_buf_size_in_bytes) { - req128_c = 1; + req128_c = true; swath_bytes_c = full_swath_bytes_packed_c/2; } } @@ -1006,8 +1006,8 @@ static void dml_rq_dlg_get_dlg_params(struct display_mode_lib *mode_lib, double min_dst_y_ttu_vblank = 0; unsigned int dlg_vblank_start = 0; - bool dual_plane = 0; - bool mode_422 = 0; + bool dual_plane = false; + bool mode_422 = false; unsigned int access_dir = 0; unsigned int vp_height_l = 0; unsigned int vp_width_l = 0; @@ -1021,7 +1021,7 @@ static void dml_rq_dlg_get_dlg_params(struct display_mode_lib *mode_lib, double hratio_c = 0; double vratio_l = 0; double vratio_c = 0; - bool scl_enable = 0; + bool scl_enable = false; double line_time_in_us = 0; // double vinit_l; @@ -1156,7 +1156,7 @@ static void dml_rq_dlg_get_dlg_params(struct display_mode_lib *mode_lib, // Source // dcc_en = src.dcc; dual_plane = is_dual_plane((enum source_format_class)(src->source_format)); - mode_422 = 0; // TODO + mode_422 = false; // TODO access_dir = (src->source_scan == dm_vert); // vp access direction: horizontal or vertical accessed vp_height_l = src->viewport_height; vp_width_l = src->viewport_width; -- 1.8.3.1