Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] virtio-mem: Assign boolean values to a bool variable
To:     Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>,
        "Michael S. Tsirkin" <mst@redhat.com>
Cc:     jasowang@redhat.com, virtualization@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org, Tian Tao <tiantao6@hisilicon.com>
References: <1611129031-82818-1-git-send-email-abaci-bugfix@linux.alibaba.com>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat GmbH
Message-ID: <81a1817d-a1f5-dfca-550c-3e3f62cf3a9d@redhat.com>
Date:   Wed, 20 Jan 2021 10:40:37 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.0
MIME-Version: 1.0
In-Reply-To: <1611129031-82818-1-git-send-email-abaci-bugfix@linux.alibaba.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 20.01.21 08:50, Jiapeng Zhong wrote:
> Fix the following coccicheck warnings:
> 
> ./drivers/virtio/virtio_mem.c:2580:2-25: WARNING: Assignment
> of 0/1 to bool variable.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
> ---
>  drivers/virtio/virtio_mem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
> index 9fc9ec4..85a272c 100644
> --- a/drivers/virtio/virtio_mem.c
> +++ b/drivers/virtio/virtio_mem.c
> @@ -2577,7 +2577,7 @@ static int virtio_mem_probe(struct virtio_device *vdev)
>  	 * actually in use (e.g., trying to reload the driver).
>  	 */
>  	if (vm->plugged_size) {
> -		vm->unplug_all_required = 1;
> +		vm->unplug_all_required = true;
>  		dev_info(&vm->vdev->dev, "unplugging all memory is required\n");
>  	}
>  
> 

Hi,

we already had a fix on the list for quite a while:

https://lkml.kernel.org/r/1609233239-60313-1-git-send-email-tiantao6@hisilicon.com

However, looks like Michael queued your patch on the vhost tree instead.

-- 
Thanks,

David / dhildenb