Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: IdyA32rCVCDh9U+fbyV2ii6Wqnpm/WC4sTSEejRzrh21NZx+z810gy7M81xtDrnugtI/wMevqV
 wVT0248MbKhg==
IronPort-SDR: ea0/FmMHB3StJdYQIaQoBimu5XQcLNU9YeInwP5wV7gJbK85SSO9l65dJ9TsYzobrMoP3u+5R/
 4i7vUyRJzxBA==
Date:   Wed, 20 Jan 2021 12:36:48 +0200
From:   Sakari Ailus <sakari.ailus@linux.intel.com>
To:     Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Cc:     Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Jacopo Mondi <jacopo+renesas@jmondi.org>,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        Biju Das <biju.das.jz@bp.renesas.com>,
        Prabhakar <prabhakar.csengg@gmail.com>
Subject: Re: [PATCH] media: i2c/Kconfig: Select FWNODE for OV772x sensor
Message-ID: <20210120103648.GI11878@paasikivi.fi.intel.com>
References: <20210120090148.30598-1-prabhakar.mahadev-lad.rj@bp.renesas.com>
 <a1c42817-e2e4-b96a-c494-742808443f6b@ideasonboard.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a1c42817-e2e4-b96a-c494-742808443f6b@ideasonboard.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Wed, Jan 20, 2021 at 10:17:14AM +0000, Kieran Bingham wrote:
> Hi Lad,
> 
> On 20/01/2021 09:01, Lad Prabhakar wrote:
> > Fix OV772x build breakage by selecting V4L2_FWNODE config:
> > 
> > ia64-linux-ld: drivers/media/i2c/ov772x.o: in function `ov772x_probe':
> > ov772x.c:(.text+0x1ee2): undefined reference to `v4l2_fwnode_endpoint_alloc_parse'
> > ia64-linux-ld: ov772x.c:(.text+0x1f12): undefined reference to `v4l2_fwnode_endpoint_free'
> > ia64-linux-ld: ov772x.c:(.text+0x2212): undefined reference to `v4l2_fwnode_endpoint_alloc_parse'
> > 
> > Fixes: 8a10b4e3601e ("media: i2c: ov772x: Parse endpoint properties")
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> 
> I see this driver uses subdev API too.
> 
> Should the driver also select VIDEO_V4L2_SUBDEV_API?

Yes, it should. Another patch? This one fixes a compilation problem.

> 
> Or is that covered sufficiently already on any platforms that would use
> the driver?
> 
> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> 
> > ---
> >  drivers/media/i2c/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> > index eddb10220953..bb1b5a340431 100644
> > --- a/drivers/media/i2c/Kconfig
> > +++ b/drivers/media/i2c/Kconfig
> > @@ -1013,6 +1013,7 @@ config VIDEO_OV772X
> >  	tristate "OmniVision OV772x sensor support"
> >  	depends on I2C && VIDEO_V4L2
> >  	select REGMAP_SCCB
> > +	select V4L2_FWNODE
> >  	help
> >  	  This is a Video4Linux2 sensor driver for the OmniVision
> >  	  OV772x camera.
> > 
> 

-- 
Sakari Ailus