Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] virtio-mem: Assign boolean values to a bool variable
To:     "Michael S. Tsirkin" <mst@redhat.com>
Cc:     Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>,
        jasowang@redhat.com, virtualization@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org, Tian Tao <tiantao6@hisilicon.com>
References: <1611129031-82818-1-git-send-email-abaci-bugfix@linux.alibaba.com>
 <81a1817d-a1f5-dfca-550c-3e3f62cf3a9d@redhat.com>
 <20210120045736-mutt-send-email-mst@kernel.org>
 <da2cb3fb-0ea5-5afd-afb5-a9e7f474e148@redhat.com>
 <20210120060301-mutt-send-email-mst@kernel.org>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat GmbH
Message-ID: <a61b016e-7896-134c-a1be-8ff8e8e6fbe2@redhat.com>
Date:   Wed, 20 Jan 2021 12:14:14 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.0
MIME-Version: 1.0
In-Reply-To: <20210120060301-mutt-send-email-mst@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 20.01.21 12:03, Michael S. Tsirkin wrote:
> On Wed, Jan 20, 2021 at 11:04:18AM +0100, David Hildenbrand wrote:
>> On 20.01.21 10:57, Michael S. Tsirkin wrote:
>>> On Wed, Jan 20, 2021 at 10:40:37AM +0100, David Hildenbrand wrote:
>>>> On 20.01.21 08:50, Jiapeng Zhong wrote:
>>>>> Fix the following coccicheck warnings:
>>>>>
>>>>> ./drivers/virtio/virtio_mem.c:2580:2-25: WARNING: Assignment
>>>>> of 0/1 to bool variable.
>>>>>
>>>>> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
>>>>> Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
>>>>> ---
>>>>>  drivers/virtio/virtio_mem.c | 2 +-
>>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
>>>>> index 9fc9ec4..85a272c 100644
>>>>> --- a/drivers/virtio/virtio_mem.c
>>>>> +++ b/drivers/virtio/virtio_mem.c
>>>>> @@ -2577,7 +2577,7 @@ static int virtio_mem_probe(struct virtio_device *vdev)
>>>>>  	 * actually in use (e.g., trying to reload the driver).
>>>>>  	 */
>>>>>  	if (vm->plugged_size) {
>>>>> -		vm->unplug_all_required = 1;
>>>>> +		vm->unplug_all_required = true;
>>>>>  		dev_info(&vm->vdev->dev, "unplugging all memory is required\n");
>>>>>  	}
>>>>>  
>>>>>
>>>>
>>>> Hi,
>>>>
>>>> we already had a fix on the list for quite a while:
>>>>
>>>> https://lkml.kernel.org/r/1609233239-60313-1-git-send-email-tiantao6@hisilicon.com
>>>
>>> Can't find that one.
>>
>> Looks like it was only on virtualization@ and a couple of people on cc.
>>
>> https://lists.linuxfoundation.org/pipermail/virtualization/2020-December/051662.html
>>
>> Interestingly, I cannot find the follow-up ("[PATCH] virtio-mem: use
>> boolean value when setting vm->unplug_all_required") in the mailing list
>> archives, even though it has virtualization@ on cc.
> 
> 
> Unsurprising that I didn't merge it then ;)

Well, you were on cc ;)

> Want to send your ack on this one?

Sure

Acked-by: David Hildenbrand <david@redhat.com>


-- 
Thanks,

David / dhildenb