Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp214347pxb;
        Wed, 20 Jan 2021 05:24:26 -0800 (PST)
X-Google-Smtp-Source: ABdhPJxZWf+8OS+c3F9vxfOOnf/SWJ5FlM+fF4x1Nd5CSa3hZdFgV225F9OPZtTwuCRTc3/1e285
X-Received: by 2002:a17:906:9747:: with SMTP id o7mr4867182ejy.107.1611149066643;
        Wed, 20 Jan 2021 05:24:26 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1611149066; cv=none;
        d=google.com; s=arc-20160816;
        b=gd6opJB/ZU7nG6RmN4HFzsRxaWfEIavJ3dHeyVR+aiFIEFyBOKDsx3zpKnaNc796QX
         yUU+h6W5TIdyeUAJshpTJbosYw9AegN8jL6ylNz1f/gEAGMF9Ta5L9ZfQy8D9/N6H+If
         KBsRf+p/jjN5B1rlTIWBWJ6thf0fUWIa7kZi3U/zS77Jljg4RqhsdbFwf3jFONUXXxGb
         IBl/rr3r02zdqkM1mvtKgvEC1gB1RTS8aIg9UQQZkCAjz4oAAOjjaxl5lS6xN7tHHJK4
         9c5bCQNrO9rQvXV7hCsMAwBEc3K3dW+NvwyPTpAwg1S01UDkYkWfe3dblSykl8OaI1op
         z5ww==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to
         :references:mime-version:dkim-signature;
        bh=/Dib82sU5arH2pQ+ODWj2A/H3qlrgt26ReauOPltmfs=;
        b=fS55QaQ2Ry+DV5G/aH2kdAIxsta4rr3fz4LF8T4CTxAz1kRjvwOfGSRREzG5PvhXLp
         hwK4M5pguo4WlTvy/OsSYZEGF7qQR2zGOSjIOYaHgbt0XLoosksGyCORx0k/Hzl/a0sg
         DexX37MveJQ8xIsT1gz/1VrgEevNCzZMpTM8EiTOtnYcnmQfSPKFxpuOImm10imISPRR
         C2/jQ7Sovh1TO+gUDSCpg2eH7LtfgEhcCt0pLep1rdT2kLwENRprpPRFZgYpHwXNBKWL
         c4glVc8L497Qx4H4lbce0HbWD9bILApKqBXH2RNho7WgMuJMA3NIzzQ72vRYo3E7jpZp
         W6iw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=A0ujDq6L;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id p1si827451edm.218.2021.01.20.05.23.58;
        Wed, 20 Jan 2021 05:24:26 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=A0ujDq6L;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728206AbhATNWc (ORCPT <rfc822;liuchenandwork@gmail.com>
        + 99 others); Wed, 20 Jan 2021 08:22:32 -0500
Received: from mail.kernel.org ([198.145.29.99]:53534 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1730970AbhATNPX (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 20 Jan 2021 08:15:23 -0500
Received: by mail.kernel.org (Postfix) with ESMTPSA id 620E323380
        for <linux-kernel@vger.kernel.org>; Wed, 20 Jan 2021 13:14:39 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1611148479;
        bh=/Dib82sU5arH2pQ+ODWj2A/H3qlrgt26ReauOPltmfs=;
        h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
        b=A0ujDq6LP+USWQhT5cpJn2rJU+bT1xQmLFDRgP2HuT6cSDLJahRAshL0DZUkmaEV9
         RXwHGyhwsktLXiJnVyaMk40vcrfpo44ydNOx5rTHSlcyls0bcSiq5RdSmsXJFd4Dii
         qMjB4mw7U6AHpmbhbHzCcSA2ducAd1fLHoOPVjw/GACi4Mk/u2llEGr0XfqngMQ1mA
         nHyLeMEJNZamlYwRyOJWZ1duJwn4n6fdAgBZyF4iRjuijHMDehcVRRqldb1mJxuU7O
         L6uLiOaruevwG4XaPRaBwQkpW/hhbzlmUknu6qR5YwTTfYEIzVeZx6YqONRh+nbq6E
         rG9b6fL40TK3g==
Received: by mail-lf1-f49.google.com with SMTP id q8so2432512lfm.10
        for <linux-kernel@vger.kernel.org>; Wed, 20 Jan 2021 05:14:39 -0800 (PST)
X-Gm-Message-State: AOAM530siJ9olIlK5GKcRXPvLTBSrpcie6mpLF7q0/bG326aQPi+fSDQ
        sa3Ld93ecUbNzZePfJH2soukW/SDBX5SjBgXOhvXVA==
X-Received: by 2002:a19:4941:: with SMTP id l1mr4149690lfj.80.1611148477497;
 Wed, 20 Jan 2021 05:14:37 -0800 (PST)
MIME-Version: 1.0
References: <20210119155953.803818-1-revest@chromium.org>
In-Reply-To: <20210119155953.803818-1-revest@chromium.org>
From:   KP Singh <kpsingh@kernel.org>
Date:   Wed, 20 Jan 2021 14:14:26 +0100
X-Gmail-Original-Message-ID: <CACYkzJ6Sar+BQELJtTRdAhFReEpusa48N_7QDnMnXzBxcJC7kw@mail.gmail.com>
Message-ID: <CACYkzJ6Sar+BQELJtTRdAhFReEpusa48N_7QDnMnXzBxcJC7kw@mail.gmail.com>
Subject: Re: [PATCH bpf-next v5 1/4] bpf: Be less specific about socket
 cookies guarantees
To:     Florent Revest <revest@chromium.org>
Cc:     bpf <bpf@vger.kernel.org>, Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Florent Revest <revest@google.com>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jan 19, 2021 at 5:00 PM Florent Revest <revest@chromium.org> wrote:
>
> Since "92acdc58ab11 bpf, net: Rework cookie generator as per-cpu one"
> socket cookies are not guaranteed to be non-decreasing. The
> bpf_get_socket_cookie helper descriptions are currently specifying that
> cookies are non-decreasing but we don't want users to rely on that.
>
> Reported-by: Daniel Borkmann <daniel@iogearbox.net>
> Signed-off-by: Florent Revest <revest@chromium.org>

Acked-by: KP Singh <kpsingh@kernel.org>