Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 20 Jan 2021 14:25:26 +0000
From:   Christoph Hellwig <hch@infradead.org>
To:     Will McVicker <willmcvicker@google.com>
Cc:     Jessica Yu <jeyu@kernel.org>,
        Masahiro Yamada <masahiroy@kernel.org>,
        Michal Marek <michal.lkml@markovi.net>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Christoph Hellwig <hch@infradead.org>,
        Saravana Kannan <saravanak@google.com>,
        linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
        kernel-team@android.com
Subject: Re: [PATCH v5] modules: introduce the MODULE_SCMVERSION config
Message-ID: <20210120142526.GA3759754@infradead.org>
References: <20210108003035.1930475-1-willmcvicker@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210108003035.1930475-1-willmcvicker@google.com>
Precedence: bulk

On Fri, Jan 08, 2021 at 12:30:35AM +0000, Will McVicker wrote:
> For example, we have a CI setup that tests new kernel changes on the
> hikey960 and db845c devices without updating their kernel modules. When
> these tests fail, we need to be able to identify the exact device
> configuration the test was using. By including MODULE_SCMVERSION, we can
> identify the exact kernel and modules' SCM versions for debugging the
> failures.

Sorry, but this still has no business in the upstream kernel as every
change to the kernel is free to just change any API.  That is whatever
you test there is a completely unsupported setup.

More importantly the "scmversion" of a module simply does not matter,
as we only support modules from the kernel tree and it thus must be the
kernel version.
be supported.

You are still trying to sneak out of tree module infrastructure in here
with a bad cover story.  Please stop doing that.