Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp281745pxb; Wed, 20 Jan 2021 07:00:26 -0800 (PST) X-Google-Smtp-Source: ABdhPJwEkoGaRo8Rj6uJDB8JEu6Suw8jBOsVfL5aJ3d+BUHkyLFV4B8XSX8RytPgi4cFiomaGlwO X-Received: by 2002:a17:906:3481:: with SMTP id g1mr6511221ejb.5.1611154825973; Wed, 20 Jan 2021 07:00:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611154825; cv=none; d=google.com; s=arc-20160816; b=mIUyZK67nL0AI4qC/I4rdk1/LDSFpZd2QgbsvBQDKtCAbhzBm7evG3/mwHj9SQmOiS GbcOH4nSVomNtlVLiteoHnB/A/B8rX8ew8WZVz5nt3/erLhliJt6OY6dG8+wdeTHT32O 1M/7hRZsT8yYAZUMTyElkjvV+YhxZkblVEMsIRt8JwhsLpIctCQ/wuD1OdrnOaTuO854 RIzGTPhy16CjEkIex4W8zvU7Me/sMYCFI+9MVSkLHNkW24XJiOxaFAcE65uekdDQNz6l clWh0vnvLiNynzx0l1FmXzp3V1yYWABWpUGD/XJxyPQRnZTaV7jEj50vFVEtFdeDSrUs tKEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version; bh=1CizkAqxvrzGVEb+o2LUdk+BtxmR/1x/VSd4w+BeqFU=; b=SkOBkLKdNUqTi8hrE9+BsOUiQzgbVtpIkBi6rIA64fEBIE/8HjRvZY1yLs+1McA3Vp VGXbKBEyrMGK4HyzfMtv0ITAHL772BwxCZ1Qe/IQtY/2P1j+zbN3hUN2giqrdwzRq7LN 9WPNMJWk+ke3Vw/H6MBpRXpINJzlB3Dr95hm5glUMoKSVHFfQqNdseHUqNo1ngC1aBux ZT+2tfPFPmMlEgw1ly5fA825ugoYk7y6uIscfF4bZyQhVTUS66ci1LlDihcpcDjtBNF2 MIs9DrvCc8SQiDuPvY7Q5Px8Wtfzu7qrlsgp+U9uF2igxME+OHCc21DAXA8Q2j6KaWLe yKxg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s19si799161eja.720.2021.01.20.07.00.00; Wed, 20 Jan 2021 07:00:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390198AbhATOzn (ORCPT + 99 others); Wed, 20 Jan 2021 09:55:43 -0500 Received: from mail-ot1-f42.google.com ([209.85.210.42]:36836 "EHLO mail-ot1-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388245AbhATO1v (ORCPT ); Wed, 20 Jan 2021 09:27:51 -0500 Received: by mail-ot1-f42.google.com with SMTP id v21so5744186otj.3; Wed, 20 Jan 2021 06:27:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1CizkAqxvrzGVEb+o2LUdk+BtxmR/1x/VSd4w+BeqFU=; b=tZJ6YsoaeMSTYePixsSsNO1H47gwE61ilDw/+9mkB9CCBiahSzIzPeggWha1aDLLVw KTYEvIuamjJ7swOaGV8CZt8kZQ2cwIwv9kZjC+FhGyeJ8RyS7YS4TFhgpd36k9nXeD2u nJ4knXODzPWW7DM5E8pWnK9HcFhvx0SNrUi1OwGPe4hIG75CYTbqcRDI51xZ9ruRv/mg BcebVcxV83tuVnFuOXeECzTi6Kh7yVTVMKumJ0kLdP6Du78uXcWCJTTzU+75SEgtVA5U 2bks0gJuFjyRJT533LrkxrZPBpXYZ9AkCOsx11Lfl8Qvz3HneLn4p0MJKBCraHBW91ww R+lg== X-Gm-Message-State: AOAM533Vf4tdzUzooGZkLUaY51KKYBdLA/l3qb2v1sfd2ejav9FOvuX3 E8or5vvD6Dw5jGE0KonrqqxpLew04aDp2GlSqR8= X-Received: by 2002:a05:6830:210a:: with SMTP id i10mr7210973otc.145.1611152828967; Wed, 20 Jan 2021 06:27:08 -0800 (PST) MIME-Version: 1.0 References: <20201218031703.3053753-1-saravanak@google.com> <20201218031703.3053753-6-saravanak@google.com> <86db7747ea6d48eebbf40a5855240d14@kernel.org> In-Reply-To: From: Geert Uytterhoeven Date: Wed, 20 Jan 2021 15:26:57 +0100 Message-ID: Subject: Re: [PATCH v1 5/5] driver core: Set fw_devlink=on by default To: Saravana Kannan Cc: Marc Zyngier , Greg Kroah-Hartman , "Rafael J. Wysocki" , Android Kernel Team , Linux Kernel Mailing List , Jisheng Zhang , Kevin Hilman , John Stultz , Nicolas Saenz Julienne , Yoshihiro Shimoda , Linux-Renesas Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Saravana, On Wed, Jan 20, 2021 at 10:40 AM Geert Uytterhoeven wrote: > On Tue, Jan 19, 2021 at 10:51 PM Saravana Kannan wrote: > > On Tue, Jan 19, 2021 at 10:08 AM Saravana Kannan wrote: > > > On Tue, Jan 19, 2021 at 1:05 AM Geert Uytterhoeven wrote: > > > > On Mon, Jan 18, 2021 at 10:19 PM Saravana Kannan wrote: > > > > > On Mon, Jan 18, 2021 at 11:16 AM Geert Uytterhoeven > > > > > wrote: > > > > > > On Mon, Jan 18, 2021 at 6:59 PM Marc Zyngier wrote: > > > > > > > On 2021-01-18 17:39, Geert Uytterhoeven wrote: > > > > > > > > On Fri, Dec 18, 2020 at 4:34 AM Saravana Kannan > > > > > > > > wrote: > > > > > > > >> Cyclic dependencies in some firmware was one of the last remaining > > > > > > > >> reasons fw_devlink=on couldn't be set by default. Now that cyclic > > > > > > > >> dependencies don't block probing, set fw_devlink=on by default. > > > > > > > >> > > > > > > > >> Setting fw_devlink=on by default brings a bunch of benefits > > > > > > > >> (currently, > > > > > > > >> only for systems with device tree firmware): > > > > > > > >> * Significantly cuts down deferred probes. > > > > > > > >> * Device probe is effectively attempted in graph order. > > > > > > > >> * Makes it much easier to load drivers as modules without having to > > > > > > > >> worry about functional dependencies between modules (depmod is still > > > > > > > >> needed for symbol dependencies). > > > > > > > >> > > > > > > > >> If this patch prevents some devices from probing, it's very likely due > > > > > > > >> to the system having one or more device drivers that "probe"/set up a > > > > > > > >> device (DT node with compatible property) without creating a struct > > > > > > > >> device for it. If we hit such cases, the device drivers need to be > > > > > > > >> fixed so that they populate struct devices and probe them like normal > > > > > > > >> device drivers so that the driver core is aware of the devices and > > > > > > > >> their > > > > > > > >> status. See [1] for an example of such a case. > > > > > > > >> > > > > > > > >> [1] - > > > > > > > >> https://lore.kernel.org/lkml/CAGETcx9PiX==mLxB9PO8Myyk6u2vhPVwTMsA5NkD-ywH5xhusw@mail.gmail.com/ > > > > > > > >> Signed-off-by: Saravana Kannan > > > > > > > > > > > > > > > > Shimoda-san reported that next-20210111 and later fail to boot > > > > > > > > on Renesas R-Car Gen3 platforms. No output is seen, unless earlycon > > > > > > > > is enabled. > > > > > > > > > > > > > > > > I have bisected this to commit e590474768f1cc04 ("driver core: Set > > > > > > > > fw_devlink=on by default"). > > > > > > > > > > > > > > There is a tentative patch from Saravana here[1], which works around > > > > > > > some issues on my RK3399 platform, and it'd be interesting to find > > > > > > > out whether that helps on your system. > > > > > > > > > > > > > > Thanks, > > > > > > > > > > > > > > M. > > > > > > > > > > > > > > [1] > > > > > > > https://lore.kernel.org/r/20210116011412.3211292-1-saravanak@google.com > > > > > > > > > > > > Thanks for the suggestion, but given no devices probe (incl. GPIO > > > > > > providers), I'm afraid it won't help. [testing] Indeed. > > > > > > > > > > > > With the debug prints in device_links_check_suppliers enabled, and > > > > > > some postprocessing, I get: > > > > > > > > > > > > 255 supplier e6180000.system-controller not ready > > > > > > 9 supplier fe990000.iommu not ready > > > > > > 9 supplier fe980000.iommu not ready > > > > > > 6 supplier febd0000.iommu not ready > > > > > > 6 supplier ec670000.iommu not ready > > > > > > 3 supplier febe0000.iommu not ready > > > > > > 3 supplier e7740000.iommu not ready > > > > > > 3 supplier e6740000.iommu not ready > > > > > > 3 supplier e65ee000.usb-phy not ready > > > > > > 3 supplier e6570000.iommu not ready > > > > > > 3 supplier e6054000.gpio not ready > > > > > > 3 supplier e6053000.gpio not ready > > > > > > > > > > > > As everything is part of a PM Domain, the (lack of the) system controller > > > > > > must be the culprit. What's wrong with it? It is registered very early in > > > > > > the boot: > > > > > > > > > > > > [ 0.142096] rcar_sysc_pd_init:442: of_genpd_add_provider_onecell() returned 0 > > > > > > > > > Looks like you found the important logs. Can you please enable all > > > > > these logs and send the early con logs as an attachment (so I don't > > > > > need to deal with lines getting wrapped)? > > > > > 1. The ones in device_links_check_suppliers() > > > > > 2. The ones in device_link_add() > > > > > 3. initcall_debug=1 > > > > > > > > I have attached[*] the requested log. > > > > > > > > > That should help us figure out what's going on. Also, what's the DT > > > > > that corresponds to one of the boards that see this issue? > > > > > > > > arch/arm64/boot/dts/renesas/r8a77951-salvator-xs.dts > > > > > > > > > Lastly, can you please pick up these 3 patches (some need clean up > > > > > before they merge) to make sure it's not an issue being worked on from > > > > > other bug reports? > > > > > https://lore.kernel.org/lkml/20210116011412.3211292-1-saravanak@google.com/ > > > > > https://lore.kernel.org/lkml/20210115210159.3090203-1-saravanak@google.com/ > > > > > https://lore.kernel.org/lkml/20201218210750.3455872-1-saravanak@google.com/ > > > > > > > > > > I have a strong hunch the 2nd one will fix your issues. fw_devlink can > > > > > handle cyclic dependencies now (it basically reverts to > > > > > fw_devlink=permissive mode for devices in the cycle), but it needs to > > > > > "see" all the dependencies to know there's a cycle. So want to make > > > > > sure it "sees" the "gpios" binding used all over some of the Renesas > > > > > DT files. > > > > > > > > These patches don't help. > > > > The 2nd one actually introduces a new failure: > > > > > > > > OF: /soc/i2c@e66d8000/gpio@20/pcie-sata-switch-hog: could not get > > > > #gpio-cells for /cpus/cpu@102 > > > > > > > > Note that my issues don't seem to be GPIO-related at all. > > > I took a look at your logs. It looks like your guess is right. It's at > > least one of the issues. > > > > You'll need to convert drivers/soc/renesas/rcar-sysc.c into a platform > > driver. You already have a platform device created for it. So just go > > ahead and probe it with a platform driver. See what Marek did here > > [1]. > > > > You probably had to implement it as an "initcall based driver" > > because you had to play initcall chicken to make sure the PD hardware > > was initialized before the consumers. With fw_devlink=on you won't > > have to worry about that. As an added benefit of implementing a proper > > platform driver, you can actually implement runtime PM now, your > > suspend/resume would be more robust, etc. > > On R-Car H1, the system controller driver needs to be active before > secondary CPU setup, hence the early_initcall(). > platform_bus_init() is called after that, so this is gonna need a split > initialization. Or a dummy platform driver to make devlinks think > everything is fine ;-) Note that adding a dummy platform driver does work. > So basically all producer DT drivers not using a platform (or e.g. i2c) > driver are now broken? > Including all clock drivers using CLK_OF_DECLARE()? Oh, of_link_to_phandle() ignores device nodes where OF_POPULATED is set, and of_clk_init() sets that flag. So rcar-sysc should do so, too. Patch sent. > $ git grep -L "\<[a-z0-9]*_driver\>" -- $(git grep -l > "\.compatible\>") | wc -l > 249 > > (includes false positives) > > I doubt they'll all get fixed for v5.12, as we're already at rc4... Still more than 100 drivers to fix? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds