Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp298914pxb; Wed, 20 Jan 2021 07:19:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJypnTSKUsVDq36dtmFnXbA5w3o/abat/xHtSahSgg5aD8BBJ62wc+61g4hDAZYekWSdfyRa X-Received: by 2002:a50:aad7:: with SMTP id r23mr7436278edc.83.1611155980800; Wed, 20 Jan 2021 07:19:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611155980; cv=none; d=google.com; s=arc-20160816; b=SgxShBOqeGe0ssyRbn8zc6YB0apMb7pmy2G5qYH+rmitOuAtOYGMx+BlLkhwkSmO99 qfYPv8VuoU4iRcCc6qyaONHr8ltSafLRNki/jIdkh38SUqdK4vnnIPrwmyAhY8S4ad6z SZfYFr5dISFe+i4A5SVTl0dy2zuOIM23wxhMBhPHOLGdZZaCcExv5eUNKG7tEqmmymZE oXp8KMLOWUJyYSIbPRj3VimmzsoajjX2+rIORsSabqDSkIuGwmoB08GPcXf7opt8YEOj PXSsjjsQdjw0K5baB/XQhEKl9cIEn48wFem8wNTr0fM7imJpiKynIJgIHBeihX/Nz3Zc xknQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=1St4xZ2R5m/RW5O5IwBO+CBB/1QCqm5eHdySX6ak2CY=; b=PjJ/zHNaSo/pw6aZ92crPYCJIHrkDxs5fdAH1pspm2JHOEJvTEDwK0Iz1YaZ0WdwZd CCmkJwEqsJDrGqHeR7UszY2v65HJ1o4LMP2mBG6ywKU8p5EU2QnOEpONX7PARkh+Va8U fX5PRYSre3GhDX2deW2x1SKYIMi5s0Ki7j3Y2fXygUI+zKZ0zQPFWwaSTBKT7K0MB3vn MamuQ9Am4oYzfMpuC2vgCAZTZDWbsGEnvaik4F3q3tHrswFFNSErjvfDZ3wLt58qAtSg /+LV8WhAQER4hfcXwWlRgeLsX4GuGHsSDkqFUaHBQor1PvFe5ZY8DMHh9xquUe0j847E oYwQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s24si703371ejd.135.2021.01.20.07.19.15; Wed, 20 Jan 2021 07:19:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390562AbhATPQO (ORCPT + 99 others); Wed, 20 Jan 2021 10:16:14 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:49730 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390953AbhATPPc (ORCPT ); Wed, 20 Jan 2021 10:15:32 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: eballetbo) with ESMTPSA id 335641F4582B From: Enric Balletbo i Serra To: Rikard Falkeborn , Benson Leung , Guenter Roeck Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] platform/chrome: Constify static attribute_group structs Date: Wed, 20 Jan 2021 16:14:38 +0100 Message-Id: <161115565913.676119.6220305847430124366.b4-ty@collabora.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210109001748.58036-1-rikard.falkeborn@gmail.com> References: <20210109001748.58036-1-rikard.falkeborn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 9 Jan 2021 01:17:48 +0100, Rikard Falkeborn wrote: > The only usage of these is to print their name in a dev_err-message, and > to pass their address to sysfs_create_group() and sysfs_remove_group(), > both which takes pointers to const. Make them const to allow the compiler > to put them in read-only memory. Applied, thanks! [1/1] platform/chrome: Constify static attribute_group structs commit: ed07d774c4b2793be4d2bfc62cf69c3e55667f5a Best regards, -- Enric Balletbo i Serra