Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] init/module: split CONFIG_CONSTRUCTORS to fix module gcov
 on UML
To:     Johannes Berg <johannes@sipsolutions.net>,
        linux-um@lists.infradead.org
Cc:     linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
        Arnd Bergmann <arnd@arndb.de>, Jessica Yu <jeyu@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>
References: <20210119121853.4e22b2506c9a.I1358f584b76f1898373adfed77f4462c8705b736@changeid>
 <8191aa4a-3bd7-5de7-1ad2-73b851128ff3@linux.ibm.com>
 <e386f13f8496330cd42e93c6d48a25b9a57a6792.camel@sipsolutions.net>
From:   Peter Oberparleiter <oberpar@linux.ibm.com>
Message-ID: <1232adfb-cbe8-5cfc-88bc-b8913d6a39c6@linux.ibm.com>
Date:   Wed, 20 Jan 2021 17:20:25 +0100
MIME-Version: 1.0
In-Reply-To: <e386f13f8496330cd42e93c6d48a25b9a57a6792.camel@sipsolutions.net>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 20.01.2021 17:09, Johannes Berg wrote:
> On Wed, 2021-01-20 at 17:07 +0100, Peter Oberparleiter wrote:
> 
>> Do you expect other users for these new config symbols? 
> 
> Probably not.
> 
>> If not it seems
>> to me that the goal of enabling module constructors for UML could also
>> be achieved without introducing new config symbols.
> 
> Yeah, true.
> 
>> For example you could suppress calling any built-in kernel constructors
>> in case of UML by extending the ifdef in do_ctors() to depend on both
>> CONFIG_CONSTRUCTORS and !CONFIG_UML (maybe with an explanatory comment).
>>
>> Of course you'd still need to remove the !UML dependency in
>> CONFIG_GCOV_KERNEL.
> 
> Right.
> 
> I can post a separate patch and we can see which one looks nicer?

Sounds good!


-- 
Peter Oberparleiter
Linux on Z Development - IBM Germany