Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210115211543.33563-1-alcooperx@gmail.com> <20210115211543.33563-3-alcooperx@gmail.com>
 <CAHp75VdQPQK8jTF3QDKx6mF1QzOg-qiuHrTiojnWn7GskokfoA@mail.gmail.com>
 <71d58a3e-2707-69d7-8074-c67235912e06@gmail.com> <CAHp75VfNumFBwbytCuA_YK1w-+kN20vRF+GhogtU+DDG3EB_7g@mail.gmail.com>
 <YAhiw+6UiUplNcLq@kroah.com>
In-Reply-To: <YAhiw+6UiUplNcLq@kroah.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Wed, 20 Jan 2021 19:09:46 +0200
Message-ID: <CAHp75Vf-ZmPuOjRYwNbURJXP3g_-m1LUDbsWtKHMvP49jseprw@mail.gmail.com>
Subject: Re: [PATCH v2 2/2] serial: 8250: Add new 8250-core based Broadcom STB driver
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Florian Fainelli <f.fainelli@gmail.com>,
        Al Cooper <alcooperx@gmail.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
        devicetree <devicetree@vger.kernel.org>,
        Jiri Slaby <jirislaby@kernel.org>,
        "open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
        USB <linux-usb@vger.kernel.org>,
        Masahiro Yamada <yamada.masahiro@socionext.com>,
        Rob Herring <robh+dt@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Jan 20, 2021 at 7:05 PM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Wed, Jan 20, 2021 at 06:47:52PM +0200, Andy Shevchenko wrote:
> > On Tue, Jan 19, 2021 at 8:16 PM Florian Fainelli <f.fainelli@gmail.com> wrote:
> > > On 1/19/2021 7:21 AM, Andy Shevchenko wrote:
> > > > On Fri, Jan 15, 2021 at 11:19 PM Al Cooper <alcooperx@gmail.com> wrote:

...

> > > Not sure this makes sense, given that the DMA hardware that was added to
> > > this UART block is only used by the UART block and no other pieces of HW
> > > in the system, nor will they ever be. Not sure it makes sense to pay the
> > > cost of an extra indirection and subsystem unless there are at least two
> > > consumers of that DMA hardware to warrant modeling it after a dmaengine
> > > driver. I also remember that Al researched before whether 8250_dma.c
> > > could work, and came to the conclusion that it would not, but I will let
> > > him comment on the specifics.
> >
> > I see. In any case I still believe that the driver can be shrinked by
> > a notable amount of lines.
>
> Patches always gladly accepted :)

Or a good review... :-)

-- 
With Best Regards,
Andy Shevchenko