Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp389824pxb; Wed, 20 Jan 2021 09:21:30 -0800 (PST) X-Google-Smtp-Source: ABdhPJx+bwoRFIJAVxc4ckLOYEF0aRzo/T7KgtC8O0PeAgYK0h3ViinG0VmZlQXOFmViTYjKoRSK X-Received: by 2002:a17:906:40d2:: with SMTP id a18mr6836667ejk.315.1611163290421; Wed, 20 Jan 2021 09:21:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611163290; cv=none; d=google.com; s=arc-20160816; b=nsENMtPsxLLDb8DDQaHXFe1+NBqpPEp05xbEjmoVNGcRWpBRPBCc4XYkcchOlk+7Tr dpC9YIHT1xz5UIm8Z6DRCoYL1qhjKVXdv+7Tz2jFYCRV+0YmJ9wZKoVtefCJKbx2l5ZE bBwEe1ObnXT+Gu4BCUQrFgKmBD5sk049wRZ8J3YDOicNf/yHV9b0XFoFSw6dyfeOFQTf npwoB1HCwuH5bPzsnnQMBFhHKlLXSFf02yZf6pM5z1PsLmzVUMwjxhAuADmIx5KzfKIe rKx9ryBRBVtjFfSVQIACy2lwMHfdQctSLVX5BALShvxROj5QM9ArtLwfbSSK2W3WypR1 wJJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Cpw+KncEffd6Qv/8M4Cl/Wk/jOfZpUJSHUccBeMw3Ok=; b=DygR7ursYhdXSiAZEuKfHHI0hUOUHCFU4Re/eWKRZAVeEBmm8rpolphl5/IdS0LiM3 x6+tlt9yj6anm6UEZ45v+VDVrLNoYBSSMvAk/LyWkjw3pNL8/WZwAw/x0AzepA/Wi4Cu 6FkpnHZzw9LlHFrKwE2XVKVHt4smCbUGHgeWmYaSgXhAvke+VUlTCFGTFNWkT00gRRly Nh3AEyaIxcO1kRmAz3WQPqf7XxhUHjqBaoEq7QUvkhIi1kKpkFzu8wLhyCH69kajqb5G L4a5ZVOb37wohrx1hes5oDxip5qxTa9q9N/RQccjRHAgUkp2z2ORiR4FNvaVwg/Kv/IG gbRQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=XAosQ5P6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x20si1100186edv.330.2021.01.20.09.21.05; Wed, 20 Jan 2021 09:21:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=XAosQ5P6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731303AbhATRSk (ORCPT + 99 others); Wed, 20 Jan 2021 12:18:40 -0500 Received: from mail.kernel.org ([198.145.29.99]:32932 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404050AbhATRSS (ORCPT ); Wed, 20 Jan 2021 12:18:18 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 07C7022CE3; Wed, 20 Jan 2021 17:17:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1611163058; bh=9WZ/m19z2HGkINVwNeYp/+wcK7hXnj4kx5NeS4ydpJU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XAosQ5P65dgOHKIO0YQi5Sj0fPMVYX1loaU/SHZ1bBzto/EbQxH7ttoCeQld4jojx 6/YFWJLma/2eAPw1Aq2WhdJ/koSKXt+Fya54smDXwV0+VU8PRakWl1//ZmXzGgZqh6 sINSZtlc9ccu8xdTcFTKpVS6uIiPHUK7T5RbmVyc= Date: Wed, 20 Jan 2021 18:17:35 +0100 From: Greg KH To: Hans de Goede Cc: Kyle Tso , linux@roeck-us.net, heikki.krogerus@linux.intel.com, badhri@google.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 0/3] AMS, Collision Avoidance, and Protocol Error Message-ID: References: <20210114145053.1952756-1-kyletso@google.com> <2211ad43-b76c-fbe9-2cc8-bb40c4ee4e89@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2211ad43-b76c-fbe9-2cc8-bb40c4ee4e89@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 20, 2021 at 02:45:02PM +0100, Hans de Goede wrote: > Hi, > > On 1/14/21 3:50 PM, Kyle Tso wrote: > > v5 https://lore.kernel.org/r/20210105163927.1376770-1-kyletso@google.com > > > > "usb: typec: tcpm: AMS and Collision Avoidance" > > - removed the signed-off > > - modified the coding style suggested from Heikki > > - added FR_SWAP AMS handling > > > > "usb: typec: tcpm: Protocol Error handling" > > - removed the signed-off > > - modified the coding style suggested from Heikki > > - modified more coding style problems (line wrapping limit) > > > > "usb: typec: tcpm: Respond Wait if VDM state machine is running" > > - no change > > I've finally gotten around to testing this. I'm happy to > report that the power-role swapping regression seen in one > of the older versions of this patch-set is gone. > > So the entire series is: > Tested-by: Hans de Goede Thanks for testing and the review. Heikki, any thoughts? thanks, greg k-h