Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp391308pxb; Wed, 20 Jan 2021 09:23:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJwFiG5Mzo7mwmDIa3a2HUrDou3XNqSOj48hcvR5CVkO8MWN89v3Eh8Zgosdl7/B8RIA6sgz X-Received: by 2002:a17:907:1629:: with SMTP id hb41mr6496759ejc.197.1611163403399; Wed, 20 Jan 2021 09:23:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611163403; cv=none; d=google.com; s=arc-20160816; b=XaWEeOTS66Yb2TVMxae0JzSC/NmCtgpong6YIdQn5isg0l1Oz1jYseU0GW+OuQNv8a z5raL82n7rcI1SRwjTBCIiuvNXneqipeEFyinTIVDURCKr6rtRWeGQU2xTZsW0qhswGu i0oe6i9uYBkHKj4a/4CdIfz4BX5QrONnJKbmZ6yiXLBLGxw63NWQPfYtJalcKrBrOkP8 pOjMC/48FWPeD+Esz8jE5326KWRDaDLkxcIKJ3Cg86bnXRjvvHP6ckl+/Rjr+qFimO5k Z3oxO17cIW/WDnZB0NzTEboRfDe7kOIaOsRFzIafTA/hASlcE9M/kYhF+A2mjURspCtb DHeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=njHdq4CWw79bFcLPgeuBg2fsC5f81lGof9afu6Csga8=; b=gGg1lxlbDk2ajUHofMjmcNWQiH2iPFzZdyw3FCiC/B0TCwN+rZRArsQXr2jOBFFUG5 wu+FzpQRm3c44yvWz3tZ7ETwRyC6yrEu/bK6iEhnSXWN7w+Q3pGlba7Lkz9n0wnQtKfA hANdj9j7WQo7qwOj/vkRdjD6U5ychEfcgOvo5jXZIy1zDHERMfGyzuSbXDRv7sBTgmhX tJdbhIfk8UmgQlcfNtCP4dTZIrqfOdWhqwEphBy5Spk2wmspp6RWWoiCSiuXdlOOhTMX /2++UKNHSBAiemfUlJlDjYGSf5qU0sEb3O+j5t2zszkHAtxUkJPSV338wxOdiQIxDK/B rYxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b="KL/r3nWb"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id eo9si861128ejc.734.2021.01.20.09.22.58; Wed, 20 Jan 2021 09:23:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b="KL/r3nWb"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732413AbhATPi6 (ORCPT + 99 others); Wed, 20 Jan 2021 10:38:58 -0500 Received: from mail.skyhub.de ([5.9.137.197]:48036 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733099AbhATOvs (ORCPT ); Wed, 20 Jan 2021 09:51:48 -0500 Received: from zn.tnic (p200300ec2f0bb000326c050203dd63ff.dip0.t-ipconnect.de [IPv6:2003:ec:2f0b:b000:326c:502:3dd:63ff]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 18FB81EC0323; Wed, 20 Jan 2021 15:50:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1611154255; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=njHdq4CWw79bFcLPgeuBg2fsC5f81lGof9afu6Csga8=; b=KL/r3nWbgivOTEP73Se90KlxqJFiaD2q7UVHIxVEc7rj/xK1eMJA8I+6geealH6SlS45Cs m/CLTc16mBOwRqZCuK2A+b52PmSqZe6puJC20sCsAX5ql8HY/YlpAQTInuxjhlr8oikvkK Gy8Zrjn9yGztBn3ZptpmRiAOGSuI1+Y= Date: Wed, 20 Jan 2021 15:50:48 +0100 From: Borislav Petkov To: Yazen Ghannam Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Smita.KoralahalliChannabasappa@amd.com, wgh@torlan.ru Subject: Re: [PATCH] EDAC/AMD64: Update scrub register addresses for newer models Message-ID: <20210120145048.GG825@zn.tnic> References: <20210116143353.7576-1-Yazen.Ghannam@amd.com> <20210118193112.GF30090@zn.tnic> <20210120144111.GB1385775@yaz-nikka.amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210120144111.GB1385775@yaz-nikka.amd.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 20, 2021 at 08:41:11AM -0600, Yazen Ghannam wrote: > We have a struct amd64_umc per channel, so putting these fixed values > there seemed redundant. Would you mind if we put this in struct > amd64_family_type? We can then set the values per family/model group > like we do with the max_mcs. Sure, that's better. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette