Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp412749pxb; Wed, 20 Jan 2021 09:56:15 -0800 (PST) X-Google-Smtp-Source: ABdhPJzg/jqaHx1zl1tVvEvQqitsYWABA9Su+7JuLrMzzUOT5afwHvdr+huz0DW7QHc/q1n66mh5 X-Received: by 2002:a05:6402:b6f:: with SMTP id cb15mr8089439edb.277.1611165374847; Wed, 20 Jan 2021 09:56:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611165374; cv=none; d=google.com; s=arc-20160816; b=mkbP4auVM74kC/TK8b0vkbU7vJDRGTYVzcum65+s8ff+uo7gcam6STkqOC9/CkM5fJ P2et9e5qi/sNnM9rPGmTjK17p0BRmkK5htEd3LXsltE6+onDWM9D+gRYdNieBslKBvZZ ZvCd5J4GZR+DbxPHrTI5QbOQXDiT7FC9ySO0STPk2aNAqjWDGOjkW2jEYLUIaAVnJFis V9h78OoWzOpHTE6Jq1IZIEGyH43k9OGdvaiUYpPZgjzCZrNLm7wmMIfVYkbqxykeJPXc NjrF65fCH5pf3K3eVeNCnKa92WCOcteKnPAdjdffoJk+2Xy0kAH0hhDj2QSxT6GUDPIH EKPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=y6ucevQqCCSFkQ4lpVVj7hWzqxFrN4WqZV9ERRep9/o=; b=LBo8nlGhfCdllJWmYVuxFmUJbrT4OWveAoORD9tY81RKKpfyxkAyV78lNObSunWRpR V2jjvwJ3nZ7J8KhrTZ3UPc753PiMvCsgDcFcKbERMTrdAVWpgC6+qG5vLwNXGpPwO50K i3k0kkk+kpSy9KBVXEeVeKbL/By7oU8ToiOtOYw3uHiNPasftRexLFI8RMGJCIhH9jOL UJyfsUx1zHGeQi0x5XlloEpNMCfvJcHPnwfEVNmdrEixRu63qtJujGTDLt5cat501biA C71jGuSdiHrJL1rvM4tPxp4fjYVMW6G8CHLzIsgZjTaxu1Md5tF79Ii30m+oEhDvh+Sx Y/Wg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=CxL80HsF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a1si1043399eds.422.2021.01.20.09.55.50; Wed, 20 Jan 2021 09:56:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=CxL80HsF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731332AbhATRue (ORCPT + 99 others); Wed, 20 Jan 2021 12:50:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387672AbhATRty (ORCPT ); Wed, 20 Jan 2021 12:49:54 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8798C061575 for ; Wed, 20 Jan 2021 09:49:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=y6ucevQqCCSFkQ4lpVVj7hWzqxFrN4WqZV9ERRep9/o=; b=CxL80HsF/MHgEvadkKwh2QBJZL PxkitZr3TY/UUv5RuC4ll1nPg2Vcz1sp0mH8FUphGQWz0Welt+PEwglmXCvF3soAGjn5TBeGzQAOi Tez+923CtOMmfujlmJ1Jd621V37jUg5+p4fUU4ENieP3Ga+l+Y9TXdYFhV+NDB5WKJsNvDkzosFIW Q+dyJ5/etrWlYJ9agwlqp52Z1rds+Kk0ghaKZlyrsnxHi7iGmZj/UO3hQzCoRQsbf6Y/qgWv9CjsZ JxseZv/FXcqTvmwbPUf1wJ2hjCfqoPWtT8sqNxQpAy8kF6kWB7jBBCzd2Nsfm7L9mugUyIMhEFI2d uufI793Q==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1l2HbL-00G0jQ-CO; Wed, 20 Jan 2021 17:49:04 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id C3F083012DF; Wed, 20 Jan 2021 18:49:00 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id B11542CEAD18E; Wed, 20 Jan 2021 18:49:00 +0100 (CET) Date: Wed, 20 Jan 2021 18:49:00 +0100 From: Peter Zijlstra To: vincent.donnefort@arm.com Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org, valentin.schneider@arm.com Subject: Re: [PATCH 3/4] cpu/hotplug: Add cpuhp_invoke_callback_range() Message-ID: References: <1610385047-92151-1-git-send-email-vincent.donnefort@arm.com> <1610385047-92151-4-git-send-email-vincent.donnefort@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1610385047-92151-4-git-send-email-vincent.donnefort@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 11, 2021 at 05:10:46PM +0000, vincent.donnefort@arm.com wrote: > + if (can_rollback_cpu(st)) > + WARN_ON(cpuhp_invoke_callback_range(false, cpu, st, > + prev_state)); > + if (ret) > /* > * DYING must not fail! > */ > WARN_ON_ONCE(ret); > - } > + if (ret) { > + > + cpuhp_reset_state(st, prev_state); > + > + if (st->state < prev_state) > + WARN_ON(cpuhp_invoke_callback_range(true, cpu, st, > + prev_state)); > } > + if (ret) > /* > * STARTING must not fail! > */ > WARN_ON_ONCE(ret); > - } Stuff like that is CodingStyle fail.