Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 20 Jan 2021 18:54:43 +0100
From:   Peter Zijlstra <peterz@infradead.org>
To:     vincent.donnefort@arm.com
Cc:     tglx@linutronix.de, linux-kernel@vger.kernel.org,
        valentin.schneider@arm.com
Subject: Re: [PATCH 3/4] cpu/hotplug: Add cpuhp_invoke_callback_range()
Message-ID: <YAhuY6PyqnNDyY44@hirez.programming.kicks-ass.net>
References: <1610385047-92151-1-git-send-email-vincent.donnefort@arm.com>
 <1610385047-92151-4-git-send-email-vincent.donnefort@arm.com>
 <YAgr8RQg6Cn66bvf@hirez.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YAgr8RQg6Cn66bvf@hirez.programming.kicks-ass.net>
Precedence: bulk

On Wed, Jan 20, 2021 at 02:11:14PM +0100, Peter Zijlstra wrote:
> On Mon, Jan 11, 2021 at 05:10:46PM +0000, vincent.donnefort@arm.com wrote:
> > @@ -157,26 +162,24 @@ static int cpuhp_invoke_callback(unsigned int cpu, enum cpuhp_state state,
> >  
> >  	if (st->fail == state) {
> >  		st->fail = CPUHP_INVALID;
> > -
> > -		if (!(bringup ? step->startup.single : step->teardown.single))
> > -			return 0;
> > -
> >  		return -EAGAIN;
> >  	}
> >  
> > +	if (cpuhp_step_empty(bringup, step)) {
> > +		WARN_ON_ONCE(1);
> > +		return 0;
> > +	}
> 
> This changes the behaviour of fail.. might be best to refactor without
> changing behaviour.
> 

Aah, the trick is in cpuhp_next_state() skipping empty states, so we'll
never get there.