Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: Xl3tBbgq2jYPC5DJfw72/jq04yzoERM42jKBg56KnKiiRp6KVxQVYF7Y3mFQJ9YMDOeGr/Ajnd
 c6Opfz4mO9iA==
IronPort-SDR: DCDblG0fvbFlCXKkDyiu6P2Stwm+aivgtqF7weg1iWd1SEqgv+DURVr3uoF53pWhAalWGAacVB
 TwclZUn5vzuQ==
From:   "Ayyathurai, Vijayakannan" <vijayakannan.ayyathurai@intel.com>
To:     "andriy.shevchenko@linux.intel.com" 
        <andriy.shevchenko@linux.intel.com>
CC:     Daniel Lezcano <daniel.lezcano@linaro.org>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "catalin.marinas@arm.com" <catalin.marinas@arm.com>,
        "will@kernel.org" <will@kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "mgross@linux.intel.com" <mgross@linux.intel.com>,
        "Wan Mohamad, Wan Ahmad Zainie" 
        <wan.ahmad.zainie.wan.mohamad@intel.com>,
        "Raja Subramanian, Lakshmi Bai" 
        <lakshmi.bai.raja.subramanian@intel.com>,
        "Seow, Chen Yong" <chen.yong.seow@intel.com>
Subject: RE: [PATCH v2 2/2] clocksource: Add Intel Keem Bay Timer Support
Thread-Topic: [PATCH v2 2/2] clocksource: Add Intel Keem Bay Timer Support
Thread-Index: AQHW3m7asVhecswsxk6nGZbrzXIbyqotqAuAgACyd4CAAGj/AIACPqnQ
Date:   Wed, 20 Jan 2021 19:18:59 +0000
Message-ID: <DM6PR11MB42506E32832BC24B900B40C8FBA20@DM6PR11MB4250.namprd11.prod.outlook.com>
References: <cover.1609306622.git.vijayakannan.ayyathurai@intel.com>
 <2a7038bc170e31a668995c367bbae018bf805dbe.1609306622.git.vijayakannan.ayyathurai@intel.com>
 <73330c8b-4633-4a13-b4b5-7405ff1661fe@linaro.org>
 <DM6PR11MB4250EB33E23178D211D0411DFBA30@DM6PR11MB4250.namprd11.prod.outlook.com>
 <20210119085050.GM4077@smile.fi.intel.com>
In-Reply-To: <20210119085050.GM4077@smile.fi.intel.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.5.1.3
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: cde5bee5-c025-442d-cc1f-08d8bd783d3b
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jan 2021 19:18:59.2810
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: GevmI6h7ffKm3R86JsVlKzVrfsoujlCa1RB6+BRw2IofFG2aCpwAqsablsosmmBadIZQqH27l9buUk8Xe680tZp/2OAGU2IWrHbAFHv3PlLMpJ+4L+ClcCVAMMgq0WRO
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB0009
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Andy,

> From: andriy.shevchenko@linux.intel.com
>=20
> > > > +	data.base =3D of_iomap(np, 2);
> > > > +	if (!data.base)
> > > > +		return -ENXIO;
> > > > +
> > > > +	ret =3D keembay_clocksource_init(np, &data);
> > > > +	if (ret)
> > > > +		goto exit;
> > > > +
> > > > +	ret =3D keembay_clockevent_init(np, &data);
> > >
> > > Is this missing ?
> > >
> >
> > Yes. Either case it goes to the exit path. So I thought of avoiding thi=
s error
> handling code.
>=20
> The point is that in success you probably won't call keembay_timer_cleanu=
p().
>=20

Yes. You are right, if I use this error handling code.

> > > 	if (ret)
> > > 		goto exit;
> > >
> > > 	return 0;
> > >
> > > > +exit:
> > > > +	keembay_timer_cleanup(np, &data);
> > > > +
> > > > +	return ret;
> > > > +}
>=20
Thanks,
Vijay