Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Reply-To: nicolas.dichtel@6wind.com
Subject: Re: [PATCH net-next 3/3] net: core: Namespace-ify sysctl_rmem_max and
 sysctl_wmem_max
To:     Menglong Dong <menglong8.dong@gmail.com>,
        Florian Westphal <fw@strlen.de>
Cc:     Jakub Kicinski <kuba@kernel.org>, christian.brauner@ubuntu.com,
        David Miller <davem@davemloft.net>,
        Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
        Menglong Dong <dong.menglong@zte.com.cn>, daniel@iogearbox.net,
        gnault@redhat.com, ast@kernel.org, ap420073@gmail.com,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>, jakub@cloudflare.com,
        bjorn.topel@intel.com, Kees Cook <keescook@chromium.org>,
        viro@zeniv.linux.org.uk, rdna@fb.com,
        Mahesh Bandewar <maheshb@google.com>,
        netdev <netdev@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
References: <20210118143932.56069-1-dong.menglong@zte.com.cn>
 <20210118143932.56069-4-dong.menglong@zte.com.cn>
 <20210120104621.GM19605@breakpoint.cc>
 <CADxym3aV9hy3UdnVWnLeLF6BnwqqrJ1MdMKNQiSa4sCWQ2+4ng@mail.gmail.com>
From:   Nicolas Dichtel <nicolas.dichtel@6wind.com>
Organization: 6WIND
Message-ID: <2e1eaded-f9e0-0da8-4dd9-0d459470cc95@6wind.com>
Date:   Wed, 20 Jan 2021 14:57:06 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <CADxym3aV9hy3UdnVWnLeLF6BnwqqrJ1MdMKNQiSa4sCWQ2+4ng@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

Le 20/01/2021 à 14:28, Menglong Dong a écrit :
[snip]
>>> For that reason, make sysctl_wmem_max and sysctl_rmem_max
>>> per-namespace.
>>
>> I think having those values be restricted by init netns is a desirable
>> property.
> 
> I just thought that having these values per-namespace can be more flexible,
> and users can have more choices. Is there any bad influence that I didn't
> realize?
You can have a look here:
https://lore.kernel.org/netdev/1501495652.1876.17.camel@edumazet-glaptop3.roam.corp.google.com/
https://patchwork.ozlabs.org/project/netdev/patch/20170726170333.24580-1-mcroce@redhat.com/


Regards,
Nicolas