Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp651424pxb; Wed, 20 Jan 2021 17:19:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJz2eWAfyVf6enAkftpxhFIDxfhGYllepd5OTHYvzuvmn/Mg6fH5AUfQSnQRCpRITslC+51m X-Received: by 2002:a17:906:707:: with SMTP id y7mr7602922ejb.212.1611191992486; Wed, 20 Jan 2021 17:19:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611191992; cv=none; d=google.com; s=arc-20160816; b=ThJx2CMnZO1GNdNzyMPdJIdJrHMLnVnzG1mgl5HRd9dvqeJjcbSYPBn9F1nMSQC94i z/rf7mtp1+87Jy83uPgB80ZAN41Reja8mmpj0EmRmdQXQxnLCD3S5eq3pMKtogfJGjZo flcahrWmgD7Bb+K5c7EawcZ6H2OEbv74xbmE6sNpzi25g7ye+GFIMhBpUuS2MUmOTI4v r6PX+29+GUZPiX5esZVlmwEQq98zOmar1CdnKYRgwLSVABQNutNNI/a9UbZCa4/wChMI Q57XOcr0rxvnvr32LZchPBU8vZlDnv+FZC9rVHB9Lbo4vGXPzw6X/ZBblraQ6oBFUkkI hKzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Jq1AAcRji3sbt9HJxWuOiHht6rg3mfcahgRhwBI4yn8=; b=pOjLX20MQyGZo2rUSb6SVM4whGmAixO1SiZ1BW6Cj01EbQydMZ9emyYK5bqLIOfeww 05um1M2Gsj15weu89ECksO8cqmLzzw3QfXzmmuYp8fs7LJfMcisokUqbSGTjRmyOLQnx v6uupR55dcPQhZVFFe304XCuvHZ3x8v+Xm6qXf9i1yY7H19gWifuylgM5a/4HOrHAJJU NRLYSaVm1c/ZwvmBzticyj5KeYW3OMYxSSODCZ59T1QIwZ74V/T5V1FAHRpj4lhidc+I q3r0z16f40IO3H2ngyjBwp5N/pBraG25xcKmGvFoauYQNvu/Z1o4CVuW+dRUZbw12qtB kMnQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="JIgRKiG/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s18si1241425eji.420.2021.01.20.17.19.28; Wed, 20 Jan 2021 17:19:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="JIgRKiG/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730801AbhATV3Q (ORCPT + 99 others); Wed, 20 Jan 2021 16:29:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732673AbhATU4R (ORCPT ); Wed, 20 Jan 2021 15:56:17 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79901C061575 for ; Wed, 20 Jan 2021 12:55:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=Jq1AAcRji3sbt9HJxWuOiHht6rg3mfcahgRhwBI4yn8=; b=JIgRKiG/OQYN3hrSSsRSF+ijyL CGVR1TPnyT+bFfVTZgkirRWLJRrErV1D+kvJHUgee5RZmYqDBUynSbUB6MWdi+14ld68owH3HnsYp UWcX9DH8bdciQtloq+aGAOLai0y4nE7zyVcglyqVo+csUXWNiTfropiQD7x8EvqY3HwLT9O4qAoxs qb5eBJH9JOLd39fXQs6W06op1AA2hbHpXyiffQ9Am8v5azr4NzTQSF8VatjGx2AsxpI1LdjGXyYjN 1qo1O0t3QRosHMLCjOvNK6j6Jc0TTzbMv3yrSy6Yu743eSCKt9fy6x/mI+BrI0dNahfqo6aoNksXb IUtKoXtQ==; Received: from 089144206130.atnat0015.highway.bob.at ([89.144.206.130] helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1l2KVP-00GCon-LY; Wed, 20 Jan 2021 20:55:16 +0000 From: Christoph Hellwig To: Greg Kroah-Hartman , Tejun Heo Cc: Siddharth Gupta , linux-kernel@vger.kernel.org Subject: [PATCH 3/3] kernfs: wire up ->splice_read and ->splice_write Date: Wed, 20 Jan 2021 21:46:31 +0100 Message-Id: <20210120204631.274206-4-hch@lst.de> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210120204631.274206-1-hch@lst.de> References: <20210120204631.274206-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Wire up the splice_read and splice_write methods to the default helpers using ->read_iter and ->write_iter now that those are implemented for kernfs. This restores support to use splice and sendfile on kernfs files. Fixes: 36e2c7421f02 ("fs: don't allow splice read/write without explicit ops") Reported-by: Siddharth Gupta Signed-off-by: Christoph Hellwig Tested-by: Siddharth Gupta --- fs/kernfs/file.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/kernfs/file.c b/fs/kernfs/file.c index b1a5cccf189ec7..c7571931214751 100644 --- a/fs/kernfs/file.c +++ b/fs/kernfs/file.c @@ -949,6 +949,8 @@ const struct file_operations kernfs_file_fops = { .release = kernfs_fop_release, .poll = kernfs_fop_poll, .fsync = noop_fsync, + .splice_read = generic_file_splice_read, + .splice_write = iter_file_splice_write, }; /** -- 2.29.2