Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] scsi/qla4xxx: convert sysfs sprintf/snprintf family to
 sysfs_emit/sysfs_emit_at
To:     Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>, njavali@marvell.com
Cc:     mrangankar@marvell.com, GR-QLogic-Storage-Upstream@marvell.com,
        jejb@linux.ibm.com, martin.petersen@oracle.com,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
References: <1611201437-111938-1-git-send-email-abaci-bugfix@linux.alibaba.com>
From:   Bart Van Assche <bvanassche@acm.org>
Message-ID: <9d745731-f8a3-98bf-3ca8-6367ef53aa8d@acm.org>
Date:   Wed, 20 Jan 2021 20:55:05 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.0
MIME-Version: 1.0
In-Reply-To: <1611201437-111938-1-git-send-email-abaci-bugfix@linux.alibaba.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/20/21 7:57 PM, Jiapeng Zhong wrote:
> -		return snprintf(buf, PAGE_SIZE, "%d.%02d.%02d (%x)\n",
> +		return sysfs_emit_at(buf, PAGE_SIZE, "%d.%02d.%02d (%x)\n",
>  				ha->fw_info.fw_major, ha->fw_info.fw_minor,
>  				ha->fw_info.fw_patch, ha->fw_info.fw_build);

From the sysfs_emit_at() source code:

WARN(... || at >= PAGE_SIZE, "invalid sysfs_emit_at: buf:%p at:%d\n",
buf, at)

In other words, this patch is wrong. sysfs_emit() should have been used
instead of sysfs_emit_at().

Bart.