Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 20 Jan 2021 19:19:10 -0800
From:   Drew Fustini <drew@beagleboard.org>
To:     Tony Lindgren <tony@atomide.com>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
        Pantelis Antoniou <pantelis.antoniou@linaro.org>,
        Pantelis Antoniou <pantelis.antoniou@gmail.com>,
        Jason Kridner <jkridner@beagleboard.org>,
        Robert Nelson <robertcnelson@beagleboard.org>
Subject: Re: [RFC PATCH v2] pinctrl: add helper to expose pinctrl state in
 debugfs
Message-ID: <20210121031910.GA252950@x1>
References: <20201218045134.4158709-1-drew@beagleboard.org>
 <CAHp75Vfwb+f3k2+mAj+jB=XsKFX-hCxx61A_PCmwz6y-YKHMcg@mail.gmail.com>
 <20201224203603.GA59600@x1>
 <CACRpkdb9RnGJbct+D-88JPDSbaVp1XS8vjhhHYosy20EPkLjaw@mail.gmail.com>
 <20210109025527.GA2918377@x1>
 <CACRpkdaOfU=OLp5D-EXK2oU9bScLZ-QjLdCSrewiSBa0SRRNwg@mail.gmail.com>
 <X/wiZjioLqcTYVfj@atomide.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <X/wiZjioLqcTYVfj@atomide.com>
Precedence: bulk

On Mon, Jan 11, 2021 at 12:03:18PM +0200, Tony Lindgren wrote:
> Hi,
> 
> * Linus Walleij <linus.walleij@linaro.org> [210109 21:14]:
> > On Sat, Jan 9, 2021 at 3:55 AM Drew Fustini <drew@beagleboard.org> wrote:
> > 
> > > I discussed my use case and this patch on #armlinux earlier this week
> > > and Alexandre Belloni suggested looking at the pinmux-pins debugfs file.
> > 
> > This sounds reasonable.
> > 
> > > This made me think that a possible solution could be to define a store
> > > function for pinmux-pins to handle something like "<pin#> <function#>".
> > > I believe the ability to activate a pin function (or pin group) from
> > > userspace would satisfy our beagleboard.org use-case.
> > >
> > > Does that seem like a reasonable approach?
> > 
> > This sounds like a good approach.
> 
> Makes sense to me too.
> 
> We may want to make it into a proper sysfs interface eventually to not
> require debugfs be enabled in .config. But that's another set of patches,
> certainly makes sense to first enable it for debugfs.
> 
> Regards,
> 
> Tony

I have added a debugfs file "pinmux-set" to pinmux.c. This allows
"<function-number> <group-number>" to be written into that file. The
function pinmux_set_write() calls ops->set_mux() with fsel and gsel.

I'll post an RFC with the code, but I am wondering if it would better
to take the function as a name and then lookup the function number
(fsel)?

thanks,
drew