Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210117042428.1497-1-alistair@alistair23.me> <20210117042428.1497-2-alistair@alistair23.me>
 <YAeSpUIzV/3dWPC+@google.com>
In-Reply-To: <YAeSpUIzV/3dWPC+@google.com>
From:   Alistair Francis <alistair23@gmail.com>
Date:   Wed, 20 Jan 2021 22:51:24 -0800
Message-ID: <CAKmqyKOFe0_JgFA1_9vemW40g-daBt5RY=S9CAXU5Yj-FftGGw@mail.gmail.com>
Subject: Re: [PATCH 2/3] input/touchscreen: Add device tree support to wacom_i2c
To:     Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc:     Alistair Francis <alistair@alistair23.me>,
        linux-input@vger.kernel.org, dl-linux-imx <linux-imx@nxp.com>,
        Sascha Hauer <kernel@pengutronix.de>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Jan 19, 2021 at 6:17 PM Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
>
> On Sat, Jan 16, 2021 at 08:24:27PM -0800, Alistair Francis wrote:
> > Allow the wacom-i2c device to be exposed via device tree.
>
> The patch seems incomplete. I see we are reading and storing properties,
> but we are not using them whatsoever, so I do not see the reason to have
> this in this form.

Good point. I am trying to split up the work, but I guess here I split
it up a little too much. I'm sending a v2 that should fix this.

Alistair

>
> Thanks.
>
> --
> Dmitry