Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp18848pxb; Wed, 20 Jan 2021 23:34:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJw1r4cx47VS2OSrTmaSBxVMMH97Z0eZLApEnPIv7bBMTuH2QnsnCxQu7QKkxCP0jEG54wTs X-Received: by 2002:a05:6402:2c5:: with SMTP id b5mr10656053edx.258.1611214481238; Wed, 20 Jan 2021 23:34:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611214481; cv=none; d=google.com; s=arc-20160816; b=g59XehEH7ge0UUArs/kmGiFvuY3baXY44YwhUbYyHGCieVhQ8wldiaQRVdHpfET8Tr 0KkrHSSo8eygfPtnaeu3b1t2y+3Tl1oNoWdlKVOxDXfN0hdGjdVPmfiAzAJtUofIPe0j FEx59FIV6Hw7BnLe76RTL7Qr4mWZsEUkJUqV6BPx5iWzUMdXH0rfyaRNNTMCB2e5i28T VxhrcYndBCdoKtqU+hTdpTxO1hzvLEJG5wBkr5vp4rCIxgsVWLg2SAupo1uJ8KQArEv3 mktHTrTszsixoh3JdlektzwxrSqxhlPNO8LwPLK/BlUzIoFbDAMYwbVJd7H7p60UGHi5 hkjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=txAUbefFUjH4meVF+ekBbIjSdPasH6EVzzxT+1U3KHQ=; b=S9NnymHH9iBt3ABMa+I5bphVvQ4yvH4+clKPEHfJEn5oaUkxtDLrFrQEY2R/eRSMzJ 6qaf/T2RQXzc3qat5AF/aiC2DSUQR5vkwKA4qeNtuXRzmS2aXiK3c65oeceCUYexrSRk dx+yxrkF1a5cvJK01UsCh51eWMtpZab467kbbFJurQ/+6Ks5LiDBW1Cx29jCnOEsjcd5 iHbIGqFABz7eqwH0XfIqWe+L/RFb72nydUA+/UMVXpIBR/OiEp7LAciGy/cHRdrHSPCQ 2ZMvru8QXPjv+iXAdAswmsO5gK1047R8qIvgXUIO38UE2VmEYOw6N92XKpr5VhUuc7Y/ 3qDA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u15si1512861ejf.716.2021.01.20.23.34.17; Wed, 20 Jan 2021 23:34:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727779AbhAUHdj (ORCPT + 99 others); Thu, 21 Jan 2021 02:33:39 -0500 Received: from out30-44.freemail.mail.aliyun.com ([115.124.30.44]:53231 "EHLO out30-44.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726320AbhAUHbn (ORCPT ); Thu, 21 Jan 2021 02:31:43 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R191e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=alimailimapcm10staff010182156082;MF=abaci-bugfix@linux.alibaba.com;NM=1;PH=DS;RN=4;SR=0;TI=SMTPD_---0UMPU06O_1611214231; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:abaci-bugfix@linux.alibaba.com fp:SMTPD_---0UMPU06O_1611214231) by smtp.aliyun-inc.com(127.0.0.1); Thu, 21 Jan 2021 15:30:54 +0800 From: Yang Li To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yang Li Subject: [PATCH] mm/swap_slots.c: remove redundant NULL check Date: Thu, 21 Jan 2021 15:30:29 +0800 Message-Id: <1611214229-11225-1-git-send-email-abaci-bugfix@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix below warnings reported by coccicheck: ./mm/swap_slots.c:197:3-9: WARNING: NULL check before some freeing functions is not needed. Reported-by: Abaci Robot Signed-off-by: Yang Li --- mm/swap_slots.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mm/swap_slots.c b/mm/swap_slots.c index 0357fbe..be9de6d 100644 --- a/mm/swap_slots.c +++ b/mm/swap_slots.c @@ -193,8 +193,7 @@ static void drain_slots_cache_cpu(unsigned int cpu, unsigned int type, cache->slots_ret = NULL; } spin_unlock_irq(&cache->free_lock); - if (slots) - kvfree(slots); + kvfree(slots); } } -- 1.8.3.1