Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp34176pxb; Thu, 21 Jan 2021 00:06:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJwJ8WTSfEuKlzCkT5QAwe3aoHuDvq5UZWUkYx6IoX7xOKhTTD/TRljNDimQvs19oldRPqqP X-Received: by 2002:aa7:d288:: with SMTP id w8mr10133879edq.241.1611216403649; Thu, 21 Jan 2021 00:06:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611216403; cv=none; d=google.com; s=arc-20160816; b=nqcLTtu2zzSzyc3wHnBRz8RmsnnkEuC8etK+W2QNsVlgt04IieU8Py9O7wCMGFnNxj ZnPILlmuFeWuJafFHQiX+5WOS8Ebaj3m9NEv6b74lUondOBEn6FKK/Z1M36oj49/8871 9B+s4t1qS7PQ68LBJ+2765Ivoe9SBZ+HSaBd1erT7IYu5zRJnTgLZnJgbxb2q39fm56p UdFnGBf22mS/tSfoxFwuZqHpL/T0B383VAaO1HM6NNcp7GUfJzlZvzp0cqL1Z96oZCK9 EXY6WHCd5hZ+etVwPny6RPBUh9Br+UApk+tS5Af+wZdXFUkuaS3Y6uBNx0lnUET8t7tU ahsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=mWzHyqXz669FFhfti2ClMiwP8HqQI9NMNZwUo9Zklh0=; b=KyYRIn2PWouflrJOVLSzAF/+ni8L3kJU7JkTFddqbLP2rqVuh73U0jAj3tYrtTLnv4 y85Ce/fh9rxalP3pYQsFzM25vZSU9xwYMi+Dgcy251uCpi8QgwoYqPPXpsdeQYU90Qg7 7tikzjlRurXjaTmrt/xtJZ6uC7AEAC+BgwZnIjX/g4jkrooI9PCaYcxEueb/PYy+JEDz Ss1pycT8vAyvWhHeaMWeCvuliGMYClN/VeKR6lCT5ZOllFUP9w2mjrMf4PQQBtea4wED JZ+jCEPucoK0DXMXGpUg8L8NNtY24bhs0nRO09x/NWpz53zea2LXOb6XtoVaVNByjY+W DgZg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hs42si1496965ejc.136.2021.01.21.00.06.19; Thu, 21 Jan 2021 00:06:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727630AbhAUIEA (ORCPT + 99 others); Thu, 21 Jan 2021 03:04:00 -0500 Received: from out30-43.freemail.mail.aliyun.com ([115.124.30.43]:42700 "EHLO out30-43.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727935AbhAUIBe (ORCPT ); Thu, 21 Jan 2021 03:01:34 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R811e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04426;MF=abaci-bugfix@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0UMPTiNr_1611216031; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:abaci-bugfix@linux.alibaba.com fp:SMTPD_---0UMPTiNr_1611216031) by smtp.aliyun-inc.com(127.0.0.1); Thu, 21 Jan 2021 16:00:50 +0800 From: Yang Li To: hannes@cmpxchg.org Cc: mhocko@kernel.org, vdavydov.dev@gmail.com, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yang Li Subject: [PATCH] mm/memcontrol: remove redundant NULL check Date: Thu, 21 Jan 2021 16:00:29 +0800 Message-Id: <1611216029-34397-1-git-send-email-abaci-bugfix@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix below warnings reported by coccicheck: ./mm/memcontrol.c:451:3-9: WARNING: NULL check before some freeing functions is not needed. Reported-by: Abaci Robot Signed-off-by: Yang Li --- mm/memcontrol.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 605f671..f6a561b 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -447,8 +447,7 @@ static void memcg_free_shrinker_maps(struct mem_cgroup *memcg) for_each_node(nid) { pn = mem_cgroup_nodeinfo(memcg, nid); map = rcu_dereference_protected(pn->shrinker_map, true); - if (map) - kvfree(map); + kvfree(map); rcu_assign_pointer(pn->shrinker_map, NULL); } } -- 1.8.3.1