Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <a60c9b90b5db4dbc40ad9cf8c0cfadc01bd4fd2c.camel@sipsolutions.net>
Subject: Re: Splicing to/from a tty
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Willy Tarreau <w@1wt.eu>,
        Linus Torvalds <torvalds@linux-foundation.org>
Cc:     Al Viro <viro@zeniv.linux.org.uk>, Christoph Hellwig <hch@lst.de>,
        Oliver Giles <ohw.giles@gmail.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date:   Thu, 21 Jan 2021 09:04:55 +0100
In-Reply-To: <20210121060522.GA23430@1wt.eu>
References: <20210118195400.GC736435@zeniv-ca>
         <20210120162608.GB740243@zeniv-ca> <20210120191116.GC740243@zeniv-ca>
         <CAHk-=wjtTC_jNL+K1Ey_wY_KpTYZOR5XwhkZ+Eu7vviVi5itDQ@mail.gmail.com>
         <20210120231439.GE740243@zeniv-ca>
         <CAHk-=widQ+oLHbm=wSrewpLgXJg_FWCZV3BERmaEAx+ZCMfmZg@mail.gmail.com>
         <20210121003835.GF740243@zeniv-ca>
         <CAHk-=whWGwcZXpqDFv-j2fcChtT1jE0ZMFCmQHp3BrSkp+XZ6A@mail.gmail.com>
         <20210121014528.GG740243@zeniv-ca>
         <CAHk-=whqZbEPt2WC6WRWrMNPqaTsx99dp74vB6FQfM4aO6biQQ@mail.gmail.com>
         <20210121060522.GA23430@1wt.eu>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 2021-01-21 at 07:05 +0100, Willy Tarreau wrote:

> I think that most users of splice() on sockets got used to falling back
> to recv/send on splice failure due to various cases not being supported
> historically (UNIX family sockets immediately come to my mind but I seem
> to remember other combinations).

Note, however, that I got here because cgit, if using sendfile(), does
*not* fall back if it fails (and thus my git tree view is currently down
because I haven't downgraded the kernel so far). That may not be common
for splice() though.

johannes