Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp39846pxb; Thu, 21 Jan 2021 00:18:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJzun/TMmxvzxa6fDZgMSQl0UFL3yF0eaHEdw8tlHQFaNWMpu3phO+tqqbRUWM0WIeO/LunD X-Received: by 2002:a05:6402:100c:: with SMTP id c12mr10653133edu.356.1611217092562; Thu, 21 Jan 2021 00:18:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611217092; cv=none; d=google.com; s=arc-20160816; b=HWW5b84a0cFc/5/fRE6egxHmhPOrxeb7ovXtzQwWgyAyq4j9O9rxBm2XunOUNFu5br kLfsG26EtP22LVRMYBR0EIAKW2nxALqr86h35MpuCwRYNdgPYzMPF3Soxpb9B11JVbEf n+UhTbnJizu36mGKWHEJUq5CGQb/ch5lPoD2X5DAhwyLczpoJ7mrh6b0Zeq7FgafbLqU AJW8ibgTi5FDUZ1MTqVZGYCsjvGL9h18rFMTrDorstDC/SEqumNdVnP3NC5kSsDqX4F3 iS6aUIfGLfz1m26qriw4cABLufDQwgFoucRQ6RLtelXfWRGpu+W5+dSeQ1VbgEFN/a6K EnCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=f7bL9E08ly3xGe0PJMBjh/rjuiHyMbSsl36cS9Sr+Jw=; b=Mbe4GrwlfHWVNEDbOqS4/l4BktQA2pEyqgeNaFZBT6XH9CwVHwYYTqvXpzRWBz0aVo fCSkXZcCTuoIn9ZqUH82hMGifgnzy/OvJYOHDRZSFsikRlPWf27PV6uZQEnNvy7zVs7n Q2clgEfebJ8dPcdXzCeKd8paA4jJvh6iZQ80d7/vaoS8tS/Apuwpz51AmJ8CraP4I+0V iAmb/lBKfXgbt/9UlPp13B65uDma1WM8j5iFgX8VNr6Y++JlF9RfadY8p3wPN7n1PW7E hdNAf29d9BttQ8HI/Jp/KZI6qyGYwS8x+BsB6Iv9O0FgTiZLnzi/spy+aCkrquunjlZX ikxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ych4A9+X; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e8si1529111ejj.540.2021.01.21.00.17.48; Thu, 21 Jan 2021 00:18:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ych4A9+X; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727001AbhAUIOj (ORCPT + 99 others); Thu, 21 Jan 2021 03:14:39 -0500 Received: from mail.kernel.org ([198.145.29.99]:51510 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726811AbhAUIN5 (ORCPT ); Thu, 21 Jan 2021 03:13:57 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id E09E92395B; Thu, 21 Jan 2021 08:13:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1611216793; bh=Jv1+7MosJtJk/47qnsHE23CojVtEBdwQu3teqjrEUG4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ych4A9+XzpZXkBsCkXP/On+u7xDemwsYafarw38F4mHDP/WP6N8atVJxSu6+bNrG7 2uH9IAL/cEmASLMwFiLsOJAgjlLujgG+ZO29Z+a+QdatEfgTsRxPsvsFSS7Hpi2i1q wRvYg7Te/pec9wrDrcpwF7jDootfX4r0APyclbKk= Date: Thu, 21 Jan 2021 09:13:09 +0100 From: Greg KH To: Dan Williams Cc: Logan Gunthorpe , Hans Verkuil , Alexandre Belloni , Alexander Viro , Dave Jiang , vishal.l.verma@intel.com, linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org Subject: Re: [PATCH 1/3] cdev: Finish the cdev api with queued mode support Message-ID: References: <161117153248.2853729.2452425259045172318.stgit@dwillia2-desk3.amr.corp.intel.com> <161117153776.2853729.6944617921517514510.stgit@dwillia2-desk3.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <161117153776.2853729.6944617921517514510.stgit@dwillia2-desk3.amr.corp.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 20, 2021 at 11:38:57AM -0800, Dan Williams wrote: > -void cdev_del(struct cdev *p) > +void cdev_del(struct cdev *cdev) > { > - cdev_unmap(p->dev, p->count); > - kobject_put(&p->kobj); > + cdev_unmap(cdev->dev, cdev->count); > + kobject_put(&cdev->kobj); After Christoph's patch series, the kobject in struct cdev does nothing, so I will be removing it. So I don't think this patch set is going to do what you want :( thanks, greg k-h