Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp48563pxb; Thu, 21 Jan 2021 00:34:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJytJMBJJbKxeVOvq+zpk4NmLbrlcvch83mKgRiQnJCSQpYhgWlZsZnilHmnssgSfEwTFyos X-Received: by 2002:a17:906:7e42:: with SMTP id z2mr528593ejr.177.1611218064711; Thu, 21 Jan 2021 00:34:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611218064; cv=none; d=google.com; s=arc-20160816; b=Uj3HF7UUzmyUMdNeR0nVHtCBUY8+6hTQwsItKHYY7wmpTavkUmq262c1jLi517VviK Tizm8piT6Xg7SaOD3WF0EFicrD+QE5sfe/AIhu02J3vyMLKndaSlk93MWOR6Nqiivnk6 IBQgzl+NM92HGEEicEtXhVzWNR2sylIYLq90M6hP0/mSEYktmbNS5l6Z9PFkEL3pU2MM NpQUMiTJr8p2FhDlhwntykjJCrVtiBJhhpGKiBXPGyzpeokeMn180VImJ2KCtXhMkuNW s7HJilo2fRvLKvU/JNT7cMYo8t4vrFmhPEYFDET5F1+vJiEb4p/MHPJtGdNhneWhq/2N XhOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=KuWF/slXz6j5bwSs/4r3Ik6fPh8wMCss7/HV/lnRsBE=; b=sNsv4xur9locY7KLI+vnpqAxGR1PnZvgAvnY7sI69/h2eUmpm96OOEW0qPm0wrvTo/ U+DvvHUgCTYbrabDVTYPQIhf0ZXIIN0HzwLHJ2u8leW2A7sEJbFUcOLHhCgV4hblFVHc /lR4QW4j1er8Jdvb1tR0FxB9oszAUFt6nBj8tlDTLv/fIdR/fg7bfRVLPcjNH46EYIhf 00yUWQUcsYZhTTBuaSpD2IKPLas1+jP9jSD1p6T3RyuTlY2yNSsH5ldtI+yA5vmiMrKB m4LDvj3AK8BwWAvcONK2fWosFoN9tzNOhQ2I1uIGlGhMeix2d1/8e4lMCuG6BVazyurc bgRQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id oz19si1550668ejb.732.2021.01.21.00.34.00; Thu, 21 Jan 2021 00:34:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727420AbhAUIaZ (ORCPT + 99 others); Thu, 21 Jan 2021 03:30:25 -0500 Received: from out30-56.freemail.mail.aliyun.com ([115.124.30.56]:56738 "EHLO out30-56.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726513AbhAUI3m (ORCPT ); Thu, 21 Jan 2021 03:29:42 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R591e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=alimailimapcm10staff010182156082;MF=abaci-bugfix@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0UMPTmlJ_1611217732; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:abaci-bugfix@linux.alibaba.com fp:SMTPD_---0UMPTmlJ_1611217732) by smtp.aliyun-inc.com(127.0.0.1); Thu, 21 Jan 2021 16:29:00 +0800 From: Yang Li To: mchehab@kernel.org Cc: sakari.ailus@linux.intel.com, gregkh@linuxfoundation.org, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Yang Li Subject: [PATCH] media: atomisp: remove redundant NULL check Date: Thu, 21 Jan 2021 16:28:51 +0800 Message-Id: <1611217731-56866-1-git-send-email-abaci-bugfix@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix below warnings reported by coccicheck: ./drivers/staging/media/atomisp/pci/sh_css_params.c:1575:2-8: WARNING: NULL check before some freeing functions is not needed. ./drivers/staging/media/atomisp/pci/sh_css_params.c:3006:2-8: WARNING: NULL check before some freeing functions is not needed. Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/staging/media/atomisp/pci/sh_css_params.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/sh_css_params.c b/drivers/staging/media/atomisp/pci/sh_css_params.c index 24fc497..569473b9 100644 --- a/drivers/staging/media/atomisp/pci/sh_css_params.c +++ b/drivers/staging/media/atomisp/pci/sh_css_params.c @@ -1575,8 +1575,7 @@ struct ia_css_isp_3a_statistics_map * return me; err: - if (me) - kvfree(me); + kvfree(me); return NULL; } @@ -3006,8 +3005,7 @@ static void free_map(struct sh_css_ddr_address_map *map) } kvfree(params); - if (per_frame_params) - kvfree(per_frame_params); + kvfree(per_frame_params); stream->isp_params_configs = NULL; stream->per_frame_isp_params_configs = NULL; -- 1.8.3.1