Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp57207pxb; Thu, 21 Jan 2021 00:53:39 -0800 (PST) X-Google-Smtp-Source: ABdhPJwNzDTEX4QgYCXCqnqTmP32LzfsgxPfvIo36fh4nLCOGTl+vmQ09Bm0YSlMhTDZ+utTosEs X-Received: by 2002:aa7:d649:: with SMTP id v9mr10202854edr.383.1611219219731; Thu, 21 Jan 2021 00:53:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611219219; cv=none; d=google.com; s=arc-20160816; b=KUI0bwmUQUoLkEyIS909Wdtc0RsaBs8q9UuJRWVpyMX1VhkEr0YXDdioHJcHaYjAb/ KDlGeMjnhHSrtrAdFyUDO3J2FVG0kk0VWGaCW5uykTqMCTiTnbFwGRgf2WrWwPPCRBIg mR4iJBSQjEycUJiKkeY9ud6+97hRiOZJsHf+/yfM4IEt5Z9DJVSBcS453akKQpPniqR9 2GJbMfggN6MwbetSFW4giw18I4+KJaL7bmuklQZH6AOk6x0MdSVi4Srv5AXRCVvUaQVA j1fcu2QdJ3jztl8l2sMGsCD7ZTj5Fp0LZJquL4qkZ0/soOWok0e3YK9fOmYABLOLGOUI oPMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=dlaROhMW6FO8ZGkXTXUg+ptOi5v9yOi8dktR2AzYtLE=; b=xXZnD71X52qJHo3uaXxO2XdSkoNEtTP+vPg2qGnbkn1oB2tqTITUP7DRqlJvltblp4 Jht6b+O766yDmLaxMTUh3C5TqAWCbtbrQtT/ITppp06h0sndQ+Ns/9uYdKi70lroki4n 3HK/Anlct2lbuudL50iX0Ds/uZ1mnm600QgNwRhk2wkaytW9wyUoMi1Z8PvXY1P3LfXV tqhYlTFELFQ+mZ1DTwHa26g7S7KB43dcNP08KZRNtuzToGVafFAuFTimcP8gFebE+glO EEqcsmjEn5AysMVsygZEzNWvz2v+utagV6soZhTSCStRvPaOnBDHSFPK9Lb7Ouo6gnUm sC1Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w24si1542259ejb.213.2021.01.21.00.53.16; Thu, 21 Jan 2021 00:53:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728103AbhAUIwK (ORCPT + 99 others); Thu, 21 Jan 2021 03:52:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728131AbhAUIvd (ORCPT ); Thu, 21 Jan 2021 03:51:33 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6745FC061757 for ; Thu, 21 Jan 2021 00:51:18 -0800 (PST) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=bjornoya.blackshift.org) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l2VgK-0000y7-3Z; Thu, 21 Jan 2021 09:51:08 +0100 Received: from hardanger.blackshift.org (unknown [IPv6:2a03:f580:87bc:d400:37fb:eadb:47a3:78d5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id 3AA0D5C9852; Thu, 21 Jan 2021 08:51:05 +0000 (UTC) Date: Thu, 21 Jan 2021 09:51:04 +0100 From: Marc Kleine-Budde To: Su Yanjun Cc: manivannan.sadhasivam@linaro.org, thomas.kopp@microchip.com, wg@grandegger.com, davem@davemloft.net, kuba@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] can: mcp251xfd: replace sizeof(u32) with val_bytes in regmap Message-ID: <20210121085104.kp5qkllzyfu6ybtj@hardanger.blackshift.org> References: <20210121083313.71296-1-suyanjun218@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="uvdzd62yprqygzpz" Content-Disposition: inline In-Reply-To: <20210121083313.71296-1-suyanjun218@gmail.com> X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --uvdzd62yprqygzpz Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 21, 2021 at 04:33:13PM +0800, Su Yanjun wrote: > No functional effect. >=20 > Signed-off-by: Su Yanjun Fails to build from source: CC [M] drivers/net/can/spi/mcp251xfd/mcp251xfd-core.o drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c: In function =E2=80=98mcp251= xfd_get_val_bytes=E2=80=99: drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c:187:22: error: invalid use o= f undefined type =E2=80=98struct regmap=E2=80=99 187 | return priv->map_reg->format.val_bytes; | ^~ rivers/net/can/spi/mcp251xfd/mcp251xfd-core.c:188:1: error: control reaches= end of non-void function [-Werror=3Dreturn-type] 188 | } | ^ cc1: some warnings being treated as errors Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --uvdzd62yprqygzpz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEK3kIWJt9yTYMP3ehqclaivrt76kFAmAJQHUACgkQqclaivrt 76kgAwgAoJfEY57+qt577cXwMuAWcpN2BrXymJSzb3emTslNlwY0SQNVl/Y0aEmy 5ffMoyK3TyA28ztLxOCdvvSssNS2DqnjvLgOIL1xmVBAatwBnzdAPFICvKpumvsZ OdyDrh4ZZUT55W6X7I+370f8KFSBN7XPReOHkUykZvZj1qg4S1g1DPjFVEDDTgyW hGcTFTg2Is5V4Lwt2LXmlfCnF/l+khF6ZakDZ1A99w0KSMTD9Vua5Gx4sqEEGYRp ap917/egq2nQkEMNqRVN0uDkS398m1mobCYvP7wf20M4fI8NyLPAM0hPgS357TBz GPiDvWHoTR4Y2iWZUcnOnjE2slMq5g== =VcRg -----END PGP SIGNATURE----- --uvdzd62yprqygzpz--