Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp70484pxb; Thu, 21 Jan 2021 01:17:13 -0800 (PST) X-Google-Smtp-Source: ABdhPJyRtT9xux2BcOWhLE6mXltH9iUqg6BhIM8FIlsiA4VcqNg7ivA2myaf212DRFmtkT94jBHb X-Received: by 2002:a17:906:7156:: with SMTP id z22mr8453018ejj.441.1611220633788; Thu, 21 Jan 2021 01:17:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611220633; cv=none; d=google.com; s=arc-20160816; b=bZCRrx6VUQw8ixH6HJeAqcoU8MLAyQhUMP2PS7wjYP74IvOxU6i08knrNw8aT/rQvQ XY/hhCC+T+3kD0h5A/Zi1vdgVmj4aqNoNgvt1jWuBUkN+wDF6YHDutKOO9xodEPAskIa UN3oXXV4aC+Fq1Qs/6jHrWfP3LIebOxgK8kLLbqPxpobI4rkeoLZKT1HTjs6L9j7rQDR tQNjgiHOF02fzxgCV6qXSp+kun317q6xc4AVuBx1PDVO84e3LY62TNQzCp8TCliBX1dl pCkWhp3TkTQakKGO6bOI5NcA9uWxFdKkfZAj72oHTHsWTGJvR/66kH1/5KXAWouUQq/a 9Edg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=AveS9y+MRqX8uZiqmdv4Y3VXGY6AARtZfUTecqrq694=; b=Y3sEBRqGgxpz24VRpkz2PZwEOtgBj8z4/pFXVIlQzsaS32bAVHCkU9t3B9xqWo3y3f Q92ZfGdN6ec5p4y67K8brXzcvDRDNsFvulkwKIW8/TdbnZtvfKqx5zUR02VVPAWIsU2j HS3jrodiOgrnHPJfrHBQ53qRU4XV5Pwo8eW+Wwa9Dkl9rYJ+zY6WFRjd0cluV599FfBT 0UTFnkSeOBI3YX2pIiQMmCjXMtVfU9r5HM+Kh6palTRjgtYgQP3bnF+ZHpcuIJ1hyJVz utquuXa6gFDfkuLgGDYt17BbV05yv9TPeMAHP0cKu392b5xtbmdQbALAb3/Qf8rtP108 Q8Kg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ak15si1544797ejc.547.2021.01.21.01.16.50; Thu, 21 Jan 2021 01:17:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728493AbhAUJOs (ORCPT + 99 others); Thu, 21 Jan 2021 04:14:48 -0500 Received: from out30-133.freemail.mail.aliyun.com ([115.124.30.133]:42823 "EHLO out30-133.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728269AbhAUJMs (ORCPT ); Thu, 21 Jan 2021 04:12:48 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R101e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04423;MF=abaci-bugfix@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0UMQ.y10_1611220314; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:abaci-bugfix@linux.alibaba.com fp:SMTPD_---0UMQ.y10_1611220314) by smtp.aliyun-inc.com(127.0.0.1); Thu, 21 Jan 2021 17:12:02 +0800 From: Yang Li To: mchehab@kernel.org Cc: sakari.ailus@linux.intel.com, gregkh@linuxfoundation.org, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Yang Li Subject: [PATCH 1/3] media: atomisp: remove redundant NULL check Date: Thu, 21 Jan 2021 17:11:50 +0800 Message-Id: <1611220312-89384-1-git-send-email-abaci-bugfix@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix below warnings reported by coccicheck: ./drivers/staging/media/atomisp/pci/runtime/isp_param/src/isp_param.c:159:4-10: WARNING: NULL check before some freeing functions is not needed. Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/staging/media/atomisp/pci/runtime/isp_param/src/isp_param.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/runtime/isp_param/src/isp_param.c b/drivers/staging/media/atomisp/pci/runtime/isp_param/src/isp_param.c index e861777..823ec54 100644 --- a/drivers/staging/media/atomisp/pci/runtime/isp_param/src/isp_param.c +++ b/drivers/staging/media/atomisp/pci/runtime/isp_param/src/isp_param.c @@ -155,8 +155,7 @@ for (mem = 0; mem < IA_CSS_NUM_MEMORIES; mem++) { for (pclass = 0; pclass < IA_CSS_NUM_PARAM_CLASSES; pclass++) { - if (mem_params->params[pclass][mem].address) - kvfree(mem_params->params[pclass][mem].address); + kvfree(mem_params->params[pclass][mem].address); if (css_params->params[pclass][mem].address) hmm_free(css_params->params[pclass][mem].address); mem_params->params[pclass][mem].address = NULL; -- 1.8.3.1