Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp72114pxb; Thu, 21 Jan 2021 01:20:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJz5CUPyUMUNb4OsRijBplXZMDk75MaMHsEob3EUSAPvsGyqfdimnFGFNWsO7wMmMuFrrXcM X-Received: by 2002:a17:906:c793:: with SMTP id cw19mr8315627ejb.246.1611220808269; Thu, 21 Jan 2021 01:20:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611220808; cv=none; d=google.com; s=arc-20160816; b=cF3Mspx5+8bM6Gn+5O312T4n2ezXBBkgxH9c0dXoH3F7bGgRIA2/k3eQas0xVhO1O2 B4pw/OWRDnjNv9arkWahmcdSqGg49LRR1bREAORZ/JS5uAj6aCgIUvaX66ZqeNhuL8Uz 01SJVXkXWRfTFZdehfUxJRtPVjPU/9306cngATVzdPMaNKSjA2t0nJ6N48uXfmKyKRyr HIkNHIZQBovON1fUlKETlayxeqf8scMWaWybIx6ac13PMTVBZIKRWaR2y6ILWX3/ZTdk kBgiHshldbv2nL8yll2XTlieNPKQaiunPW0YRmu5OuSzaPR04uOappXz+zMUc/bUEKe/ R7wA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from; bh=wBIwQJv9AKwVtl33bDe5I5FmVT5Sx00VTvjvH2okqMM=; b=DPPQO2Dyy9DyWDD1MCtGHZbOkg9EU26tkfZ7XTHCnXEWQJuAxo2QBqgRLQq08FQykq osT0Q4Yoh2aqPAiqctmYwtFBHV7t6jC5w/oqchAD+8o3wU6U+jsMUa4vJLl2ztBeHSLi BtyZmQJ5DkJnv7zDCv83rjD4+tL5kRWo3a+M/N+TWL5rVl/t/UTQjhMxuSOebGiQW9Gb w0JGce9LI3zwGOMG9V+sc57mU/fpqL/uxQneOf3MAGa1RquycTkbFSq3qp8Gq7rb59Qf u8YSmWXKBTcBzhmbPCfZS6932y4S0tnQP4Eo6dYZWt2ax+tso8usoWZR1V8iTaNzmY7g F+cQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t7si1893609edy.137.2021.01.21.01.19.44; Thu, 21 Jan 2021 01:20:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728519AbhAUJQ3 (ORCPT + 99 others); Thu, 21 Jan 2021 04:16:29 -0500 Received: from out30-54.freemail.mail.aliyun.com ([115.124.30.54]:42473 "EHLO out30-54.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728332AbhAUJN0 (ORCPT ); Thu, 21 Jan 2021 04:13:26 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R591e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04423;MF=abaci-bugfix@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0UMQ.y10_1611220314; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:abaci-bugfix@linux.alibaba.com fp:SMTPD_---0UMQ.y10_1611220314) by smtp.aliyun-inc.com(127.0.0.1); Thu, 21 Jan 2021 17:12:06 +0800 From: Yang Li To: mchehab@kernel.org Cc: sakari.ailus@linux.intel.com, gregkh@linuxfoundation.org, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Yang Li Subject: [PATCH 3/3] media: atomisp: remove redundant NULL check Date: Thu, 21 Jan 2021 17:11:52 +0800 Message-Id: <1611220312-89384-3-git-send-email-abaci-bugfix@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1611220312-89384-1-git-send-email-abaci-bugfix@linux.alibaba.com> References: <1611220312-89384-1-git-send-email-abaci-bugfix@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix below warnings reported by coccicheck: ./drivers/staging/media/atomisp/pci/atomisp_cmd.c:4269:2-8: WARNING: NULL check before some freeing functions is not needed. ./drivers/staging/media/atomisp/pci/atomisp_cmd.c:4626:2-8: WARNING: NULL check before some freeing functions is not needed. Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/staging/media/atomisp/pci/atomisp_cmd.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c index 592ea99..72a6cac 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c +++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c @@ -4265,8 +4265,7 @@ int atomisp_set_parameters(struct video_device *vdev, apply_parameter_failed: if (css_param) atomisp_free_css_parameters(css_param); - if (param) - kvfree(param); + kvfree(param); return ret; } @@ -4626,8 +4625,7 @@ int atomisp_fixed_pattern(struct atomisp_sub_device *asd, int flag, err: if (ret && res) ia_css_frame_free(res); - if (tmp_buf) - vfree(tmp_buf); + vfree(tmp_buf); if (ret == 0) *result = res; return ret; -- 1.8.3.1