Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1611207098-11381-1-git-send-email-hejinyang@loongson.cn> <1611207098-11381-2-git-send-email-hejinyang@loongson.cn>
In-Reply-To: <1611207098-11381-2-git-send-email-hejinyang@loongson.cn>
From:   Huacai Chen <chenhuacai@kernel.org>
Date:   Thu, 21 Jan 2021 17:28:31 +0800
Message-ID: <CAAhV-H6vvnMqW_xCgUDFiT2mpntY5SFT4M-6jZQ714FabbckQg@mail.gmail.com>
Subject: Re: [PATCH v2 1/4] MIPS: process: Remove unnecessary headers inclusion
To:     Jinyang He <hejinyang@loongson.cn>
Cc:     Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>,
        "open list:MIPS" <linux-mips@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Paul Burton <paulburton@kernel.org>,
        Jun-Ru Chang <jrjang@realtek.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Reviewed-by: Huacai Chen <chenhuacai@kernel.org>

On Thu, Jan 21, 2021 at 1:44 PM Jinyang He <hejinyang@loongson.cn> wrote:
>
> Some headers are not necessary, remove them and sort includes.
>
> Signed-off-by: Jinyang He <hejinyang@loongson.cn>
> ---
> v2:
> - Remove useless header inclusion.
>
>  arch/mips/kernel/process.c | 39 ++++++++++-----------------------------
>  1 file changed, 10 insertions(+), 29 deletions(-)
>
> diff --git a/arch/mips/kernel/process.c b/arch/mips/kernel/process.c
> index d7e288f..d737234 100644
> --- a/arch/mips/kernel/process.c
> +++ b/arch/mips/kernel/process.c
> @@ -9,50 +9,31 @@
>   * Copyright (C) 2004 Thiemo Seufer
>   * Copyright (C) 2013  Imagination Technologies Ltd.
>   */
> +#include <linux/cpu.h>
>  #include <linux/errno.h>
> -#include <linux/sched.h>
> -#include <linux/sched/debug.h>
> -#include <linux/sched/task.h>
> -#include <linux/sched/task_stack.h>
> -#include <linux/tick.h>
> -#include <linux/kernel.h>
> -#include <linux/mm.h>
> -#include <linux/stddef.h>
> -#include <linux/unistd.h>
> -#include <linux/export.h>
> -#include <linux/ptrace.h>
> -#include <linux/mman.h>
> -#include <linux/personality.h>
> -#include <linux/sys.h>
>  #include <linux/init.h>
> -#include <linux/completion.h>
>  #include <linux/kallsyms.h>
> -#include <linux/random.h>
> -#include <linux/prctl.h>
> +#include <linux/kernel.h>
>  #include <linux/nmi.h>
> -#include <linux/cpu.h>
> +#include <linux/personality.h>
> +#include <linux/prctl.h>
> +#include <linux/sched.h>
> +#include <linux/sched/debug.h>
> +#include <linux/sched/task_stack.h>
>
>  #include <asm/abi.h>
>  #include <asm/asm.h>
> -#include <asm/bootinfo.h>
> -#include <asm/cpu.h>
>  #include <asm/dsemul.h>
>  #include <asm/dsp.h>
>  #include <asm/fpu.h>
> +#include <asm/inst.h>
>  #include <asm/irq.h>
> -#include <asm/mips-cps.h>
> +#include <asm/irq_regs.h>
> +#include <asm/isadep.h>
>  #include <asm/msa.h>
>  #include <asm/mipsregs.h>
>  #include <asm/processor.h>
>  #include <asm/reg.h>
> -#include <linux/uaccess.h>
> -#include <asm/io.h>
> -#include <asm/elf.h>
> -#include <asm/isadep.h>
> -#include <asm/inst.h>
> -#include <asm/stacktrace.h>
> -#include <asm/irq_regs.h>
> -#include <asm/exec.h>
>
>  #ifdef CONFIG_HOTPLUG_CPU
>  void arch_cpu_idle_dead(void)
> --
> 2.1.0
>