Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 21 Jan 2021 10:44:22 +0100
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Su <suyanjun218@gmail.com>
Cc:     manivannan.sadhasivam@linaro.org, thomas.kopp@microchip.com,
        wg@grandegger.com, davem@davemloft.net, kuba@kernel.org,
        lgirdwood@gmail.com, broonie@kernel.org, linux-can@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] can: mcp251xfd: replace sizeof(u32) with val_bytes in
 regmap
Message-ID: <20210121094422.h5tjjyhsn7gvhlrm@hardanger.blackshift.org>
References: <20210121091005.74417-1-suyanjun218@gmail.com>
 <20210121092115.dasphwfzfkthcy64@hardanger.blackshift.org>
 <5ed3d488-3ea6-cc07-a04d-73a6678d772a@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="zrug2yvgvouevx6t"
Content-Disposition: inline
In-Reply-To: <5ed3d488-3ea6-cc07-a04d-73a6678d772a@gmail.com>
Precedence: bulk


--zrug2yvgvouevx6t
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jan 21, 2021 at 05:33:40PM +0800, Su wrote:
> The sizeof(u32) is hardcoded. IMO it's better to use the config value in
> regmap.

I got why you want to change this. Please update the patch description, com=
ment
on the increase of the object size and address the other issues I pointed o=
ut.
I think it makes no sense to have the function mcp251xfd_get_val_bytes() as=
 you
have to use several regmaps anyways.

> > > No functional effect.
> > Not quite:
> >=20
> > scripts/bloat-o-meter shows:
> >=20
> > add/remove: 0/0 grow/shrink: 3/0 up/down: 104/0 (104)
> > Function                                     old     new   delta
> > mcp251xfd_handle_tefif                       980    1028     +48
> > mcp251xfd_irq                               3716    3756     +40
> > mcp251xfd_handle_rxif_ring                   964     980     +16
> > Total: Before=3D20832, After=3D20936, chg +0.50%

Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--zrug2yvgvouevx6t
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEK3kIWJt9yTYMP3ehqclaivrt76kFAmAJTPQACgkQqclaivrt
76kmLAf/Yexh9D+O2IOdOK2R9xP9k0PGIxsk6HhUz2wMqvIP8HBRd/Tuqj+5hFQU
NO17xotVj9XVvvYHSI4mp8zfMyLVz7rylzimdLuxrGDaKmeMA+txcEU6BASpkXpy
OadMbHTaor2CZt4blUVeeQcTGKhwH35cSIaRfXLcDr5dZADwwQcz5l1TkNe4dxEw
9qFaWENDjwoqnkwFVjQGVCM04kthvcQA8kRtwq0ne3VpoiyY1phSbzYO784CO3+F
+uj0zJUNqUwpa5zA2HG6zby4h4af2hca8mdZQNlAmgyJzTCmQ9rjpPGHKiBuSZ+A
PPN08M3HNARYwFYda7Qwhs9XW2t36Q==
=stZm
-----END PGP SIGNATURE-----

--zrug2yvgvouevx6t--