Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932089AbWINWqX (ORCPT ); Thu, 14 Sep 2006 18:46:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932091AbWINWqX (ORCPT ); Thu, 14 Sep 2006 18:46:23 -0400 Received: from dvhart.com ([64.146.134.43]:7138 "EHLO dvhart.com") by vger.kernel.org with ESMTP id S932089AbWINWqW (ORCPT ); Thu, 14 Sep 2006 18:46:22 -0400 Message-ID: <4509DBBD.6000304@mbligh.org> Date: Thu, 14 Sep 2006 15:46:21 -0700 From: Martin Bligh User-Agent: Mozilla Thunderbird 1.0.7 (X11/20051011) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Ingo Molnar Cc: Michel Dagenais , Mathieu Desnoyers , linux-kernel@vger.kernel.org, Christoph Hellwig , Andrew Morton , Ingo Molnar , Greg Kroah-Hartman , Thomas Gleixner , Tom Zanussi , ltt-dev@shafik.org, fche@redhat.com Subject: Re: [PATCH 0/11] LTTng-core (basic tracing infrastructure) 0.5.108 References: <20060914033826.GA2194@Krystal> <20060914112718.GA7065@elte.hu> <450971CB.6030601@mbligh.org> <20060914174306.GA18890@elte.hu> <4509B5A4.2070508@mbligh.org> <20060914201448.GA7357@elte.hu> <1158267906.5068.49.camel@localhost> <20060914222318.GA25004@elte.hu> In-Reply-To: <20060914222318.GA25004@elte.hu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 997 Lines: 30 > i disagree. Consider the following example from LTT: ... > trace_socket_sendmsg(sock, sock->sk->sk_family, > sock->sk->sk_type, > sock->sk->sk_protocol, > size); ... > what do the 5 extra lines introduced by trace_socket_sendmsg() tell us? > Nothing. They mostly just duplicate the information i already have from > the function declaration. They obscure the clear view of the function: ... > the resulting visual and structural redundancy hurts. Couldn't that be easily fixed by just doing trace_socket_sendmsg(sock, size); and have it work out which esoteric parts of the sock we want to trace, and which we don't? Is much less visually invasive, and gives the same effect. M. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/