Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp186584pxb; Thu, 21 Jan 2021 04:52:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJzl/sD0cZA4uGpco1IHks4bp2ygKBQ4BBSGRwwDuC2LtsPBqoz8+6esrGSBwvYICjzeV2ui X-Received: by 2002:a17:906:f988:: with SMTP id li8mr9415723ejb.84.1611233563992; Thu, 21 Jan 2021 04:52:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611233563; cv=none; d=google.com; s=arc-20160816; b=VoBVVvLRvizTWbxA8Uf80ls2KEXq88LbbqAP8xiVjt84ABNaGZS1o48Ury/+nDsNz8 m0IrhTBZCPVR6UD101cho4nq3ywlOSVdifUoHFVO5Ok9EJeZSu/VGvFXmvE8atoHhTEk Fn/MUJWamOP+Dxk1mCGtxh93bizDnmIX2zaMeLD4L1vxJtP7rjYt2Gws1qbbJjwjXzn1 KdVNnndbXrGjo5URRaWKS6x+BhhA+3XbI2q7VU/gzvIVYkoLYwjOq/hUty98niLKQ56j H8upxTmrqSxuhsQEk26/HX5xc3X9+khAyZWqYId6u6EUN5cqYJMPQdqUWlDDhcjAf5rx ehcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=pchBZ7HrMs8fZphopy3YDMD9Pzv91Q8ikc/LwQCGD9A=; b=SjgXDuyCL2A1ikxBHqw5ENMbGF5yEVyHUqd0u8HRYzx8Cb/bsAHACOsflBbnv/XfrQ B24g/cyLoPokR9+X8zulRr5AS9OqKln53n2dTxw1mEpkSM2Lvn9VkZUUtmBfsV1Iz9fg C7h3LbXFxjrb25lIKF1DAHEwGvIXxEznku+5kRl0f2ZG7eNANTYx16OfzOo6azbF6kSK tJxMyp+FYgZdrQBYQ5QpknMHcc33SIO60SrY2pEgo0Y+rQrN4CuXm/5c6pXoo/TgOIlq jyoZEOjsiYDSxp1PyohLikx4Dy90JjqcStThlPPLZ9zj5V9KgIGZt2K+YxPdXYEbfuEA 4lbQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b="Qo7/tKnF"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c14si2067464edv.132.2021.01.21.04.52.20; Thu, 21 Jan 2021 04:52:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b="Qo7/tKnF"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730845AbhAUMtG (ORCPT + 99 others); Thu, 21 Jan 2021 07:49:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731453AbhAUMs1 (ORCPT ); Thu, 21 Jan 2021 07:48:27 -0500 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3744C061757 for ; Thu, 21 Jan 2021 04:47:46 -0800 (PST) Received: by mail-pj1-x1031.google.com with SMTP id x20so1606295pjh.3 for ; Thu, 21 Jan 2021 04:47:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=pchBZ7HrMs8fZphopy3YDMD9Pzv91Q8ikc/LwQCGD9A=; b=Qo7/tKnFyoY63WscJuG87dCR0YHTLw4CuGfhNpL027Ij1ktidD14qE1r0pPniXYlsK 2gCnCtdtvfrEx2OCmB2KG48Pu4wjmh2X7jxjUYI1nqYqtjk0/Q0A+xjDA8ynIYzV+5PA gEp6wH5Xa6gzI3P7E4KOBBF+8QhSFkgqhk3UgubMDoH2F9tObgSjI4HDNjBCHkRVSb7V /FYzj8b5ah+97R5TGGlkxVIhPt+lcBEQppuxkeymQVlNofcjLlQLE4vzZyPaNDLBF5Gi q6Hh2KNuOy6alvDcQ6vVJGpg1+SlGXmJIjiKGJXMgRONl0F+EI4Bnmt4WhkTaFvquZp+ e7vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=pchBZ7HrMs8fZphopy3YDMD9Pzv91Q8ikc/LwQCGD9A=; b=ErM2mg57EXWGDbsBGnje9W9NpYVLz6PJfV/CYiMP+xz5TQkvX9CGP5tj8QucLQN2PV oRLY/8NiEiSn8kcVLWAa7ow4bjtuJ+jRH5ttVTqtwJn9C29azyNagIdrSBeBOf3ZEHpa zaK27ypIZOC0OMxtJajha6hiOgBmZUbzVHsh7FWXGGuDyE3jBNpp6/h0txF1Z10Stwvf ZXIVXBzzkCs6oCQyk4fX7GiE774NCeI6IBtlMDh9lxyPyCTYzLkFt9W1kVIl/edUle/G zOmAZL1tysyctUTq8qN6tOG7CxtGMTKqW+W66nQNaspb8VujeNriSby+x2iac+THWFQQ UFTg== X-Gm-Message-State: AOAM5324ClPrey3wuKh6YotxY3bg2+hKlhTfjT+d7mssX64BsirpQ5dB kB/V/TYTvsAtr5sHmpV/Q84ghmvaVHT03w== X-Received: by 2002:a17:90b:11d4:: with SMTP id gv20mr11776619pjb.116.1611233265990; Thu, 21 Jan 2021 04:47:45 -0800 (PST) Received: from [192.168.4.41] (cpe-72-132-29-68.dc.res.rr.com. [72.132.29.68]) by smtp.gmail.com with ESMTPSA id e17sm5889996pjh.39.2021.01.21.04.47.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Jan 2021 04:47:45 -0800 (PST) Subject: Re: [PATCH] lightnvm: fix memory leak when submit fails To: Pan Bian , Matias Bjorling Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210121072202.120810-1-bianpan2016@163.com> From: Jens Axboe Message-ID: <55045608-01cb-d5af-682b-5a213944e33d@kernel.dk> Date: Thu, 21 Jan 2021 05:47:43 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210121072202.120810-1-bianpan2016@163.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/21/21 12:22 AM, Pan Bian wrote: > The allocated page is not released if error occurs in > nvm_submit_io_sync_raw(). __free_page() is moved ealier to avoid > possible memory leak issue. Applied, thanks. General question for Matias - is lightnvm maintained anymore at all, or should we remove it? The project seems dead from my pov, and I don't even remember anyone even reviewing fixes from other people. -- Jens Axboe