Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp406043pxb; Thu, 21 Jan 2021 09:48:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJxEGcrqmd4AFL9voIQIFErtZIWF1i7O69fuwBKMyUSrXLcXBBcMZY/ZAgp6RazHfNO2MXkQ X-Received: by 2002:a17:907:3f1f:: with SMTP id hq31mr414387ejc.205.1611251314528; Thu, 21 Jan 2021 09:48:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611251314; cv=none; d=google.com; s=arc-20160816; b=BN5jDgKzFrNgOKr23lFjIsZsCL8IaVmaYfSHzRSe/Kf0erqi/1DQZ6iSIpHYBSWkDD PPF1lUnvo5xHqIU3s4hzPHC4tfns0sxUk6SyRGwzMMMfXkGRBjKcoFV3t34ZGDSwiIym 4n1WeBX0Q8P9081YFD6pFhZGxDkKlvc16aNwumKsi7qHeRjS+am9sjucUtnB1UIhireb JuqIqMjYcNEQFmSkRkiYDYiPKEFvGrQlqWdhkjEw/6qhC1jEf7XA2tViwYocpzTzyPVY 2JSGNjWSvCasq7bg3xpgDdqvtMj2Fj+1Vd1cEShZJXKFJQcxQZAvgkBxzw1ULj0ELdfA ap7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=LYdocfnK9JKzsksQGpz6268BG+qgHgRUAyZlay8CQ+s=; b=liknLLilnIVBTfN5sXEYl3gdQAyGU2DiCjqv7SlgKwQr9XohVxMru0tnStg3XH7w/g LvghP94gZDnLNIHp3oLRcHMgrKXHTMD6IyEomOIzAFB1cxMHxai3mP8QUcWVbKHqfwQp wXr4mMz3RAj3Py582BYCUHnDHPqdCBXwGnIGdZwaESqQ4tHM+SfPUTQXaAH8J8fLW8Y/ kscisCForuH/hWeRhXEN6OTC+zlnz8cDe72/VA3w4J+i17WG921wiF78HisQt2DhZCWe Wmxld7BFDvfk4LUVvaH0Y4IB9kC1QX3GI5MtuZ0/tI0A+cRoDyyqS56fvh1BXlX/4+X1 yTUA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id de13si1873129edb.279.2021.01.21.09.48.10; Thu, 21 Jan 2021 09:48:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388858AbhAURoV (ORCPT + 99 others); Thu, 21 Jan 2021 12:44:21 -0500 Received: from frasgout.his.huawei.com ([185.176.79.56]:2392 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388997AbhAURn0 (ORCPT ); Thu, 21 Jan 2021 12:43:26 -0500 Received: from fraeml710-chm.china.huawei.com (unknown [172.18.147.207]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4DM8kc4HQfz67bkH; Fri, 22 Jan 2021 01:38:32 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml710-chm.china.huawei.com (10.206.15.59) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 21 Jan 2021 18:42:44 +0100 Received: from [10.210.167.120] (10.210.167.120) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2106.2; Thu, 21 Jan 2021 17:42:43 +0000 Subject: Re: [PATCH v2 3/3] perf vendor events: Add Fujitsu A64FX V1.2 pmu event To: Shunsuke Nakamura CC: , , , , References: <20210121105425.2695843-1-nakamura.shun@jp.fujitsu.com> <20210121105425.2695843-4-nakamura.shun@jp.fujitsu.com> From: John Garry Message-ID: Date: Thu, 21 Jan 2021 17:41:26 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: <20210121105425.2695843-4-nakamura.shun@jp.fujitsu.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.210.167.120] X-ClientProxiedBy: lhreml704-chm.china.huawei.com (10.201.108.53) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/01/2021 10:54, Shunsuke Nakamura wrote: > + { > + "PublicDescription": "This event counts each correction to the predicted program flow that occurs because of a misprediction from, or no prediction from, the branch prediction resources and that relates to instructions that the branch prediction resources are capable of predicting.", > + "EventCode": "0x10", > + "EventName": "BR_MIS_PRED", I think that we need to the same here as the IMPDEF recommended events - add a common JSON to reduce the duplication. I had done work on this for current CPUs, but never got it finished. Let me check the status. Cheers, John Ps, arm have put JSONs here for their cores: https://github.com/ARM-software/data/tree/master/pmu But unfortunately the schema does not suit perf. I raised an issue, but no response. I'm just wondering if you hand copied the JSON data. > + "BriefDescription": "This event counts each correction to the predicted program flow that occurs because of a misprediction from, or no prediction from, the branch prediction resources and that relates to instructions that the branch prediction resources are capable of predicting." > + },