Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp430627pxb; Thu, 21 Jan 2021 10:23:57 -0800 (PST) X-Google-Smtp-Source: ABdhPJxpNqTdIHBjhnICGjwkY3a9MpfinCjYh5p5hMPrEriIJC0KLcTTgbusphC5nciuz3qNb/0L X-Received: by 2002:a17:907:96a2:: with SMTP id hd34mr531112ejc.494.1611253437340; Thu, 21 Jan 2021 10:23:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611253437; cv=none; d=google.com; s=arc-20160816; b=sBeNsYNF0PpqFknXgFGKBwlWqOag2WDn94reqUTJjVc+m+sSQUdZZwgwXhpl9ZiuUB ZS5ZpDGDo3Djm79eaQ4SqG5DZurGzepipACmLjrCXXVxLax/OLxPDqTs5paHzFpTFGzj xiIxqTgx7DwUNcFm160VdylRHc2yThJDdr0Vj2KHDcWyweK9b/M2V1WufEhrad6daWt1 DckOOvuuBb9z/1H2U9lqHbB3jRKhKJJsGk0Jrt80bwjsZYmwmhZstazdSthnYGFbsaSN +mpTn4OLij9NbicEonLu7zajOWMZrJvayC1gGoaBPymEDmDCaYhcSCmHF3eBPOf+beI0 0B3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=9OzBBRrfmy6B78sTnFKqWyzV9iRKtaDILsh8A4jm2r0=; b=UbkxaZ6G4PDEO1Pb2yWUP10bMQnh3Se/565HV+FCe0NogWJnaZsMUTNpFxY+r417RG vny6D7Q6DCzMmeiW0pV2p7v7FHR/MRhwW/Deohs8L1xNzraFNhQF3YbrYkiXHnmBiHh+ dekYNjC/eVaHaWFLAhp4iACsDnNyxI4795SBQbv6mvtBGKl5pnlykN8ZhxYm1rUIwKY9 uyXrbcEPDr/GLSfprMKVXT3/3bro7vwMFh/N5ZRTGGuiPgF0dtAmsgaqxq9X4BxugWCp sm07U70iZZbDKhOd55yiL5rmHC5Sn0crMbSsmaCFe9/CFY9rGsAkNrTGTasdyED2/7Bt nP+Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dm10si1818392ejc.64.2021.01.21.10.23.32; Thu, 21 Jan 2021 10:23:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389705AbhAUSU3 (ORCPT + 99 others); Thu, 21 Jan 2021 13:20:29 -0500 Received: from out30-45.freemail.mail.aliyun.com ([115.124.30.45]:54673 "EHLO out30-45.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728253AbhAUJo2 (ORCPT ); Thu, 21 Jan 2021 04:44:28 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R191e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04357;MF=abaci-bugfix@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0UMQMPHG_1611222203; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:abaci-bugfix@linux.alibaba.com fp:SMTPD_---0UMQMPHG_1611222203) by smtp.aliyun-inc.com(127.0.0.1); Thu, 21 Jan 2021 17:43:44 +0800 From: Yang Li To: josh.h.morris@us.ibm.com Cc: pjk1939@linux.ibm.com, axboe@kernel.dk, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Yang Li Subject: [PATCH] rsxx: remove redundant NULL check Date: Thu, 21 Jan 2021 17:43:22 +0800 Message-Id: <1611222202-114248-1-git-send-email-abaci-bugfix@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix below warnings reported by coccicheck: ./drivers/block/rsxx/dma.c:948:3-8: WARNING: NULL check before some freeing functions is not needed. Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/block/rsxx/dma.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/block/rsxx/dma.c b/drivers/block/rsxx/dma.c index 1914f54..0574f44 100644 --- a/drivers/block/rsxx/dma.c +++ b/drivers/block/rsxx/dma.c @@ -944,8 +944,7 @@ int rsxx_dma_setup(struct rsxx_cardinfo *card) ctrl->done_wq = NULL; } - if (ctrl->trackers) - vfree(ctrl->trackers); + vfree(ctrl->trackers); if (ctrl->status.buf) dma_free_coherent(&card->dev->dev, STATUS_BUFFER_SIZE8, -- 1.8.3.1