Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp465124pxb; Thu, 21 Jan 2021 11:16:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJzoKk2I4XMoVvl0X4IGyniZWCH3LP76N9sxDh3288Gr9ZJ+RZisgcXFmmi6l+O6y7VRqyTX X-Received: by 2002:aa7:ca51:: with SMTP id j17mr537575edt.124.1611256577065; Thu, 21 Jan 2021 11:16:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611256577; cv=none; d=google.com; s=arc-20160816; b=uiaW2U5EaUMHGXbc2OMDzxidKuczWBQSwHB5OsnYaWZUV7GZSMQiTURKuMnQJ70L6D M60vdTaqe0G8L2rA8o1OjYYL9f4e1EgtaaXXEnqjs0f0o2K7JBg7cU1c37UIalnwtqQy npT8bAg7wrXIiWPmA22wRyxyssIsLl0oW5nbpluss065qfI7U0Tqs/Mg/vBy3Yv3a72i haKw5W+dgbWU6Z4IGBrVgWIfLBM7gA/P6QIWRyHiryLPhIO4LTU9ObMVADLd6++q8UKo qI0FeWcRhLus/ooKisorCmQU8pGBsp/7WdsjwqblDj4hWvbFfLIQr4BgpSFiMGUQcQ6n fg1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=BkHJvJ/tUGTEHfEOr9fafQWaNOm71KojzkRGHoMtMy4=; b=O16Ypw0E4UqOzf/OZxdYPUZjc++6T/kPXUO9unMSrRYukaAAAcAppBpx+PRk9gC9ga JPNnVhI4z7szzQZU9+DAvTYuRQvNSBWdkj6865+disYqh+/zSVIz5RA6K6DuW86MjTJh FkpjRHSKl7rBp6uAKlRuTCZoe5KrZb/+JxdhHMeHNlPMdFFqV5FoQ2wkVr/6VJED/T6E ZKHXJdcOD06BHl61nfkvnBYt6En57Gm69Si2WJTjumOxAAq9fgQrdkh3je8RtQ14Hvxe FObGtW2L6QMZbVNS/16NEZlrHCY44TYYdKZPmTGeT+kc93C6hlfI7wtsJlGJt9RSSiKy 7O1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ilpozm4o; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y11si2599335edp.516.2021.01.21.11.15.51; Thu, 21 Jan 2021 11:16:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ilpozm4o; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726175AbhAUTNo (ORCPT + 99 others); Thu, 21 Jan 2021 14:13:44 -0500 Received: from mail.kernel.org ([198.145.29.99]:39040 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726982AbhAUTNO (ORCPT ); Thu, 21 Jan 2021 14:13:14 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8597E221E7; Thu, 21 Jan 2021 19:12:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1611256349; bh=gePeo1d++9CotISBWeKzhTR/pKZ+NFGN4GknjJNIk/A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ilpozm4oEOgOeuinhxdzZwVAmejw2ovGgagbCX3evNiZlJet+cOeVyYnSZqtO85SV oiFMzKeozXMWhu1hFdKYmcSU5u/N+kqS7b2OKuaTCaW8HjEjkly0+XGkTFSOARcGhV Q3/T09iuuH2ArriOXnC25AaHh15SeUXCAxPmwoQc= Date: Thu, 21 Jan 2021 20:12:26 +0100 From: Greg Kroah-Hartman To: Michael Walle Cc: Saravana Kannan , "Rafael J. Wysocki" , stable@vger.kernel.org, kernel-team@android.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] driver core: Fix device link device name collision Message-ID: References: <20210110175408.1465657-1-saravanak@google.com> <10c82099cb39f176dde96c16d9cc6100@walle.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <10c82099cb39f176dde96c16d9cc6100@walle.cc> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 21, 2021 at 08:01:24PM +0100, Michael Walle wrote: > Hi, > > Am 2021-01-10 18:54, schrieb Saravana Kannan: > > The device link device's name was of the form: > > -- > > > > This can cause name collision as reported here [1] as device names are > > not globally unique. Since device names have to be unique within the > > bus/class, add the bus/class name as a prefix to the device names used > > to > > construct the device link device name. > > > > So the devuce link device's name will be of the form: > > :--: > > > > [1] - > > https://lore.kernel.org/lkml/20201229033440.32142-1-michael@walle.cc/ > > > > Cc: stable@vger.kernel.org > > Fixes: 287905e68dd2 ("driver core: Expose device link details in sysfs") > > Reported-by: Michael Walle > > Tested-by: Michael Walle > > Signed-off-by: Saravana Kannan > > --- > > Greg, any news here? Burried in other patches... I'll go pick this up now, sorry for the delay. greg k-h