Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] perf metricgroup: Fix system PMU metrics
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
CC:     Joakim Zhang <qiangqing.zhang@nxp.com>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>,
        "alexander.shishkin@linux.intel.com" 
        <alexander.shishkin@linux.intel.com>,
        "jolsa@redhat.com" <jolsa@redhat.com>,
        "namhyung@kernel.org" <namhyung@kernel.org>,
        "irogers@google.com" <irogers@google.com>,
        "kjain@linux.ibm.com" <kjain@linux.ibm.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linuxarm@openeuler.org" <linuxarm@openeuler.org>
References: <1611050655-44020-1-git-send-email-john.garry@huawei.com>
 <DB8PR04MB67957F13AE831ECC67EFFD7BE6A30@DB8PR04MB6795.eurprd04.prod.outlook.com>
 <b25f0861-1cec-3ac8-a0ef-8e9e94c4e662@huawei.com>
 <4a876638-3c92-4a49-1925-0ff20c5d42b7@huawei.com>
 <DB8PR04MB67951BF5DBE4524CB13BAAE4E6A20@DB8PR04MB6795.eurprd04.prod.outlook.com>
 <c3d8d635-33ab-8d7e-6efc-6a589aebeb52@huawei.com>
 <20210121203136.GD356537@kernel.org>
From:   John Garry <john.garry@huawei.com>
Message-ID: <f4e26095-c172-cf32-cb6e-3baaf6d739cd@huawei.com>
Date:   Thu, 21 Jan 2021 21:40:48 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.1.2
MIME-Version: 1.0
In-Reply-To: <20210121203136.GD356537@kernel.org>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 21/01/2021 20:31, Arnaldo Carvalho de Melo wrote:
>> They are not normally broken like that. Normally we test beforehand, but
>> these cases were missed here by me. However if you were testing them
>> previously, then it would be expected that you had tested them again for the
>> final patchset which was merged.
>   
>> Anyway, we can look to add metric tests for these.
>   
>> @Arnaldo, I will send separate formal patch for this today.
> Hi John, can you please take a look at my tmp.perf/urgent branch and see
> if all is well, i.e. the versions of these patches are the ones that
> should be merged and that all the patches discussed are there?
> 
> For your convenience:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/log/?h=tmp.perf/urgent

Hi Arnaldo,

Yeah, that looks fine. I gave it a quick spin also without issue.

Cheers,
John