Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 21 Jan 2021 14:46:27 -0800
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Jarkko Sakkinen <jarkko@kernel.org>
Cc:     Tianjia Zhang <tianjia.zhang@linux.alibaba.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>, Shuah Khan <shuah@kernel.org>,
        haitao.huang@intel.com, Kai Huang <kai.huang@intel.com>,
        x86@kernel.org, linux-sgx@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        linux-kselftest@vger.kernel.org,
        Jia Zhang <zhang.jia@linux.alibaba.com>
Subject: Re: [PATCH] mm: Optimizing error condition detection in
 do_mprotect_pkey()
Message-Id: <20210121144627.64a60437fe97786596f389d0@linux-foundation.org>
In-Reply-To: <YAg+QHhczqtTZt4Z@kernel.org>
References: <20210118133310.98375-1-tianjia.zhang@linux.alibaba.com>
        <YAg+QHhczqtTZt4Z@kernel.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 20 Jan 2021 16:29:20 +0200 Jarkko Sakkinen <jarkko@kernel.org> wrote:

> 
> 
> On Mon, Jan 18, 2021 at 09:33:10PM +0800, Tianjia Zhang wrote:
> > Obviously, the error variable detection of the if statement is
> > for the mprotect callback function, so it is also put into the
> > scope of calling callbck.
> > 
> > Reported-by: Jia Zhang <zhang.jia@linux.alibaba.com>
> > Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
> 
> No fixes tag, no description what this commit does. Nothing
> makes sense to me.

It's a little cleanup.  Makes the flow at this site consistent with the
other places where this function handles errors.  I added a bit to the
changelog mentioning this.