Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210120064415.16977-1-yejune.deng@gmail.com> <20210120102238.GA825@zn.tnic>
In-Reply-To: <20210120102238.GA825@zn.tnic>
From:   Yejune Deng <yejune.deng@gmail.com>
Date:   Fri, 22 Jan 2021 09:27:48 +0800
Message-ID: <CABWKuGUw_fz6vfcUB=u9Uk2EnM_GNZ06BZE=j33o8dUJbwm-GQ@mail.gmail.com>
Subject: Re: [PATCH] x86/fpu/xstate: calculate the number by sizeof and offsetof
To:     Borislav Petkov <bp@alien8.de>
Cc:     tglx@linutronix.de, mingo@redhat.com, x86@kernel.org,
        hpa@zytor.com, dave.hansen@linux.intel.com, yu-cheng.yu@intel.com,
        tony.luck@intel.com, fenghua.yu@intel.com,
        kan.liang@linux.intel.com, viro@zeniv.linux.org.uk,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Thank you for your suggestion=EF=BC=81

On Wed, Jan 20, 2021 at 6:22 PM Borislav Petkov <bp@alien8.de> wrote:
>
> On Wed, Jan 20, 2021 at 02:44:15PM +0800, Yejune Deng wrote:
> > In fpstate_sanitize_xstate(), use memset and offsetof instead of '=3D 0=
',
> > and use sizeof instead of a constant.
> >
> > Signed-off-by: Yejune Deng <yejune.deng@gmail.com>
> > ---
> >  arch/x86/kernel/fpu/xstate.c | 10 +++-------
> >  1 file changed, 3 insertions(+), 7 deletions(-)
> >
> > diff --git a/arch/x86/kernel/fpu/xstate.c b/arch/x86/kernel/fpu/xstate.=
c
> > index 5d8047441a0a..2e75630c86e9 100644
> > --- a/arch/x86/kernel/fpu/xstate.c
> > +++ b/arch/x86/kernel/fpu/xstate.c
> > @@ -161,20 +161,16 @@ void fpstate_sanitize_xstate(struct fpu *fpu)
> >        * FP is in init state
> >        */
> >       if (!(xfeatures & XFEATURE_MASK_FP)) {
> > +             memset(fx, 0, offsetof(struct fxregs_state, mxcsr));
>
> I'd prefer the explicit zeroing instead of having to look at
> fxregs_state and where the offset of mxcsr is.
>
> > +             memset(fx->st_space, 0, sizeof(fx->st_space));
>
> This is ok I guess.
>
> >               fx->cwd =3D 0x37f;
> > -             fx->swd =3D 0;
> > -             fx->twd =3D 0;
> > -             fx->fop =3D 0;
> > -             fx->rip =3D 0;
> > -             fx->rdp =3D 0;
> > -             memset(&fx->st_space[0], 0, 128);
> >       }
> >
> >       /*
> >        * SSE is in init state
> >        */
> >       if (!(xfeatures & XFEATURE_MASK_SSE))
> > -             memset(&fx->xmm_space[0], 0, 256);
> > +             memset(fx->xmm_space, 0, sizeof(fx->xmm_space));
>
> This too.
>
> --
> Regards/Gruss,
>     Boris.
>
> https://people.kernel.org/tglx/notes-about-netiquette