Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210121170836.GA4948@lemon.iwr.uni-heidelberg.de> <2438641.b0YrFlWa0f@kista>
In-Reply-To: <2438641.b0YrFlWa0f@kista>
From:   Chen-Yu Tsai <wens@csie.org>
Date:   Fri, 22 Jan 2021 11:09:18 +0800
Message-ID: <CAGb2v64CFoj5gLtZvVu8Hhdy1SAdqLd-pPwT0APh-FYymZnP8Q@mail.gmail.com>
Subject: Re: [PATCH v2] ARM: dts: sun7i: a20: bananapro: Fix ethernet node
To:     Hermann Lauer <Hermann.Lauer@iwr.uni-heidelberg.de>
Cc:     Jernej Skrabec <jernej.skrabec@siol.net>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        Maxime Ripard <mripard@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        devicetree <devicetree@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Fri, Jan 22, 2021 at 3:54 AM Jernej Škrabec <jernej.skrabec@siol.net> wrote:
>
> Dne četrtek, 21. januar 2021 ob 18:08:36 CET je Hermann Lauer napisal(a):
> > BPi Pro needs TX and RX delay for Gbit to work reliable and avoid high
> > packet loss rates. The realtek phy driver overrides the settings of the
> > pull ups for the delays, so fix this for Banana Pro.
> >
> > Signed-off-by: Hermann Lauer <Hermann.Lauer@uni-heidelberg.de>
>
> Much better. Now the only thing missing is "Fixes" tag, which references
> commit which introduced the issue. Probably this will be the commit which
> added ethernet node. This tag is important for deciding which commits should
> be backported to stable releases. Take a look in v1 for M2U fixes tag.
>
> Btw, each version should have changelog under "---" line, so maintainers and
> reviewers know what changed.

The subject line should also be more concise. "Fix ethernet phy-mode" reads
much better than "Fix ethernet node", which could mean a number of things.

ChenYu