Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp831294pxb; Thu, 21 Jan 2021 23:37:29 -0800 (PST) X-Google-Smtp-Source: ABdhPJxBnBmMDCOkXNTPmp+gr+pIxP4t+6amFCGTrAcQZekU7E88iB1YsvtPPV1zdLfntkHJk83n X-Received: by 2002:a17:906:bfcc:: with SMTP id us12mr2086158ejb.163.1611301049132; Thu, 21 Jan 2021 23:37:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611301049; cv=none; d=google.com; s=arc-20160816; b=GMFTYMcWkP40Mun/nQPF5xbLwpAFmw+f1tDb/I2FnhZ6fH+yu+FM4pdpwRkVBcqTr6 LLQ6S8jgn8DBGhoaVl/XA8bA3VN+GZSBdoqkJIHZsA0D7VKz0LWR4SsvP3T/QO5O4kC3 9AZSIWO8b2NAcIvWkQOlxOuUNQ44jim21QZq26bLZ0PsmY1tMyuL6Nckp4KG/T4Hbs4U 64Oy4FAwdB4qlehwgLQkTrmuc3lOlA+6Y7NG9jPD1d/3xpaJE3Y39erglCTgcpNXu6Vt o3FaqzuFuDdhS+pUk7jt0rsnePr0nHY1kA3ta1YxiopUVfJHvjbVV9EYmpg9erhMvP5Y frVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=w3kZnWJeN1e8BhvJnBqNiKY0mfHVTydAcms0FvG2GHk=; b=BS8NHqV6DnqPWoGL9GzYKj6KyJuzUDOM5EvweAt/vkJT0TZyoGGdUrzdDIjfQJNhEV mjOwlXG8TNPT40oXs89MOHvimpNu+23E0f9/i6f7BBO3itP5Hw9r56jEDcPJQ2PQVfn9 dhybD6X2CkrhSfuN3yHyMdesk05rZ1wzm+bbgoyMK7BqhozWZYxrlB/IlMov1uhY2sAO /mK3NNY6zKioDnzxKULcR4sAOzetzpKtwp9AYuLazOUS9yhM6rFMTkPJ+8xBMPz4L4F4 x9J0QJvheyuPVTttnOXqUTqzMNdGDQbFkKcQbXScAs8+tobgu5628djg3GPrp2HK3kVM fk9g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id be15si3209899edb.171.2021.01.21.23.37.05; Thu, 21 Jan 2021 23:37:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727096AbhAVHgM (ORCPT + 99 others); Fri, 22 Jan 2021 02:36:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727056AbhAVHgF (ORCPT ); Fri, 22 Jan 2021 02:36:05 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D8AEC06178C for ; Thu, 21 Jan 2021 23:35:20 -0800 (PST) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=bjornoya.blackshift.org) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l2qxq-0007E4-Mh; Fri, 22 Jan 2021 08:34:38 +0100 Received: from hardanger.blackshift.org (unknown [IPv6:2a03:f580:87bc:d400:aed1:e241:8b32:9cc0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id 9F94B5CA50A; Fri, 22 Jan 2021 07:34:32 +0000 (UTC) Date: Fri, 22 Jan 2021 08:34:31 +0100 From: Marc Kleine-Budde To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Wim Van Sebroeck , Guenter Roeck , William Breathitt Gray , Greg Kroah-Hartman , "Rafael J. Wysocki" , Pau Oliva Fora , Dmitry Torokhov , Mauro Carvalho Chehab , Wolfgang Grandegger , "David S. Miller" , Jakub Kicinski , Matthew Wilcox , Hannes Reinecke , "James E.J. Bottomley" , "Martin K. Petersen" , Finn Thain , Michael Schmitz , Jaroslav Kysela , Takashi Iwai , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-scsi@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH v1 2/2] isa: Make the remove callback for isa drivers return void Message-ID: <20210122073431.a3igyqh3rucmiy5y@hardanger.blackshift.org> References: <20210121204812.402589-1-uwe@kleine-koenig.org> <20210121204812.402589-3-uwe@kleine-koenig.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zjvnr6y4kfwj4bce" Content-Disposition: inline In-Reply-To: <20210121204812.402589-3-uwe@kleine-koenig.org> X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --zjvnr6y4kfwj4bce Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 21, 2021 at 09:48:12PM +0100, Uwe Kleine-K=C3=B6nig wrote: > The driver core ignores the return value of the remove callback, so > don't give isa drivers the chance to provide a value. >=20 > Adapt all isa_drivers with a remove callbacks accordingly; they all > return 0 unconditionally anyhow. >=20 > Signed-off-by: Uwe Kleine-K=C3=B6nig > --- > drivers/net/can/sja1000/tscan1.c | 4 +--- For the can driver: Acked-by: Marc Kleine-Budde Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --zjvnr6y4kfwj4bce Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEK3kIWJt9yTYMP3ehqclaivrt76kFAmAKgAUACgkQqclaivrt 76nKFwf/Qh+ytJZ22nqfhmCPbPHzMEovze0rf40PzuBbydukQ2E77J1a91Ol+M6I 1ETmnULm8kVPDDxAcJDMCpVjyMJxgwLzxAFUbO/AXMpj94QvNurQZQfJvFSuDDIi b8bMue+b3+Bir9bDAQW+GAfmyMa6ARm5kpQFvnnMvLOerD9r3iPfMvMFmAM3tlpJ QBlvhC3avamtLNyYuNZUDq4Mq8AqsJOHy+0GHptbO7JGN6TS7tkuUo4blKU4XI2j JizmoGti3M6q+jHuUDOnLpHh6JDaetW68A+M4ggQIhoFVEvbS93ROd8v7exaUwrK f/iFuhnPc/++doJnCc4XvQg1N02pYA== =HgrA -----END PGP SIGNATURE----- --zjvnr6y4kfwj4bce--