Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp861801pxb; Fri, 22 Jan 2021 00:40:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJxJx5eiw179HVFP5zfk0Z/+9hTA8cjf/ad1UENEI1RdwbDJOw0UX5zN/7wxvtW1yFCHm5xk X-Received: by 2002:a17:907:3e02:: with SMTP id hp2mr2177158ejc.411.1611304824163; Fri, 22 Jan 2021 00:40:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611304824; cv=none; d=google.com; s=arc-20160816; b=dyQJxJLjhF57pZJDgSTwH+ryi/PQfMwW3GwzMC94+sqok9lXY2z8y7jPwsLWUueAC2 Xo6p0/4JFVsemdDSbp9E+Q2IvduoQbT9tlPmrYrW5yRJN1/D2QTlMo4s7SjD5Wbw4Tpt kXBaoe/9uN53gwgNUblrvc09uLOS/7RhPAFNoUImoIVEyXVVR00w7/inRLqoYL/KgQIq WbUkZukzsUTfiWFnBSqQj4oro3REj+qcdYAcznYI9llsL799n8U8zXWAvofxF5Yql8+g vqnygIi5bXbrGcTP8JFltqVUvzz3FddT3NKEt0UG9mU7Hq8HsOQvtdqEoWt25dVAv6+8 922Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=s5NV7pUlYHUeVs4NRWVd9pbXlSXeLdI/F3w2WMqKRLM=; b=iGrE4BG952+XBE12rev83wdQ/FzPplbDWEWNe1gGspudidZWAfl+QBd+Dq84HbKohg lvhBU3B48YGbv0Bfj7e5yNQg2xqcaGDSvTGvvOFuIRRTy4xSjlFplmJeIrSLCXeZQZSL px/rxM2vDDuVBCsx4sbW1sAHuWd4CXFrJCTQFa7racumW2lHmKLev9syBsKvnwmApWWX k3P9W69rhlxRfsh+yPSSOZOP2MWjEf7oFZVz/+pVXCip0BiyRh/0kbOqh+wKjQAUyJ3h dvXuIDGbIETrkAA9izmupcw2JCp5QtdYVShcIftJrb6M3DQesaF3hmbBikPoRiyq5737 3HVw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w24si2733594ejb.213.2021.01.22.00.40.00; Fri, 22 Jan 2021 00:40:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726983AbhAVIgV (ORCPT + 99 others); Fri, 22 Jan 2021 03:36:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726716AbhAVIcJ (ORCPT ); Fri, 22 Jan 2021 03:32:09 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CB03C061786 for ; Fri, 22 Jan 2021 00:31:19 -0800 (PST) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=bjornoya.blackshift.org) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l2rqa-0004fJ-MY; Fri, 22 Jan 2021 09:31:12 +0100 Received: from hardanger.blackshift.org (unknown [IPv6:2a03:f580:87bc:d400:aed1:e241:8b32:9cc0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id 043E05CA589; Fri, 22 Jan 2021 08:31:09 +0000 (UTC) Date: Fri, 22 Jan 2021 09:31:09 +0100 From: Marc Kleine-Budde To: Su Yanjun Cc: manivannan.sadhasivam@linaro.org, thomas.kopp@microchip.com, wg@grandegger.com, davem@davemloft.net, kuba@kernel.org, linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] can: mcp251xfd: replace sizeof(u32) with val_bytes in regmap Message-ID: <20210122083109.7gyxdwi2dlo3ptjj@hardanger.blackshift.org> References: <20210122081334.213957-1-suyanjun218@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5h6qemvvzzz5qhue" Content-Disposition: inline In-Reply-To: <20210122081334.213957-1-suyanjun218@gmail.com> X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --5h6qemvvzzz5qhue Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 22, 2021 at 04:13:34PM +0800, Su Yanjun wrote: > The sizeof(u32) is hardcoded. It's better to use the config value in > regmap. >=20 > It increases the size of target object, but it's flexible when new mcp ch= ip > need other val_bytes. >=20 > Signed-off-by: Su Yanjun Applied to linux-can-next/testing. Thanks, Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --5h6qemvvzzz5qhue Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEK3kIWJt9yTYMP3ehqclaivrt76kFAmAKjUoACgkQqclaivrt 76m+Cwf/QmCkqwzxOCPGlj7JWUKqIeOMCNJWBFJzqnV6mMaihyIwiPHsollFQpyE tmmZl2bcJ+N1zq2BfDQiK/3WksXbIgqhFg5gGhhgfA/Co4i9wq/EsgJcocKb0+Zq fl5R2JZKDQf8h2GN/qOP96+vUnXie8vr6cKpExlPH2Nm4cmC0ekjW0kYb33XNkvo E5XzfdewZBOoyxb50nFn/yvkM3GxirMlR3NhvVp4sQxugzpWCkekBcOseMiWY2Sp xt3sLwZfLoOblu791qIB+2uAWwJgG5V2UJWwTZMRI2eT/mDeKuIePFn9LH+w2Wgv 6jrwq/1o8+CjBNw5CEbSdLttBQ/d+w== =YbTG -----END PGP SIGNATURE----- --5h6qemvvzzz5qhue--